GithubHelp home page GithubHelp logo

Comments (11)

git-hulk avatar git-hulk commented on May 24, 2024 3

@StarlightIbuki @chronolaw This issue seems to have happened while get_all_upstreams returns nil + error, but error was swallowed : https://github.com/Kong/kong/blob/3.0.0/kong/runloop/balancer/healthcheckers.lua#L419.

It should have the same issue in latest version, should we check the error and don't iterate the get_all_upstreams if it returns nil + error? like below:

function healthcheckers_M.stop_healthcheckers(delay)
  local upstreams, err =  upstreams.get_all_upstreams()
  if err ~= nil {
    return err
  }
  for _, id in pairs() do
  ...
end

And log the error message where calls the stop_healthcheckers.

from kong.

chronolaw avatar chronolaw commented on May 24, 2024 1

@oowl , could you take a look? thanks.

from kong.

StarlightIbuki avatar StarlightIbuki commented on May 24, 2024

Is there any other error log with the error or the critical level?
Also, we always recommend updating to the latest version.

from kong.

zhangxinars avatar zhangxinars commented on May 24, 2024

I didn't see any other error logs.

from kong.

StarlightIbuki avatar StarlightIbuki commented on May 24, 2024

How often does this occur? It sounds like a previously-fixed bug. Could you also try with the latest version?

from kong.

chronolaw avatar chronolaw commented on May 24, 2024

Kong gateway 3.0 is EOL, could you upgrade it to the latest or LTS version and try again?

from kong.

oowl avatar oowl commented on May 24, 2024

Hi @git-hulk, We have fixed this bug in the master branch, Please be patient to wait for the next major version release. It will be included.

from kong.

git-hulk avatar git-hulk commented on May 24, 2024

@oowl That's cool, thank you!

from kong.

dubuqingfeng avatar dubuqingfeng commented on May 24, 2024

failed the initial dns/balancer resolve for 'UPSTREAM_HOST' with: failed to get from node cache: could not acquire callback lock: timeout

Hello, we have checked the relevant logs and found that they should be related to this.
And it can be confirmed that 500 is not related to the fix above.

from kong.

dubuqingfeng avatar dubuqingfeng commented on May 24, 2024

Can this be reopened?

from kong.

oowl avatar oowl commented on May 24, 2024

@dubuqingfeng Hi, You can open a new issue, and I will be happy to help you investigate.

from kong.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.