Comments (3)
I have rebased my proxy-wasm refactor branch atop main and now am blocked by the re-introduction of these test cases. Instead of producing an HTTP 500 at runtime, I think a better behavior is to exit the process altogether and prevent nginx from starting. Now, since initialization happens in init_worker, it cannot be tested since Test::Nginx cannot detect --- must_die
when worker initialization failed (which is the reason why we don't check rc
in (void) ngx_wavm_load()
in init_process
, which as recently attempted to change in #143). Today I'm looking at alternatives. I thought I had already solved this issue in the past by initializing the VM twice: once in the master process initialization to verify all modules are valid (and exit there if needed), and then a second time in init_process
which would not fail if it was invoked (since master would have already exited). Maybe it was the V8 work that removed this behavior? I am less and less convinced that V8 introduced anything valuable to the project (especially since it isn't particularly more performant than other runtimes).
from ngx_wasm_module.
Yes, initializing the V8 engine twice doesn't work, it needs to be a global singleton.
from ngx_wasm_module.
Fixed in #150 - we now prevent worker processes from starting when modules cannot be properly loaded.
from ngx_wasm_module.
Related Issues (20)
- [V8] fix release process HOT 5
- [V8] release.yml is still failing HOT 6
- Host functions should perform memory bound and alignment checks
- wasmx-nightly-20220912-v8-amd64-macos fails to initialize
- Deprecated warnings in GitHub Actions
- Add ngx-wasm-rs to cargo linting CI job
- Build Wasmer with LLVM support HOT 1
- Fix V8 builds in ArchLinux build image HOT 1
- V8 trap handler support in ARM HOT 3
- Fix loading filters from OpenResty with dynamic ngx_wasm_module.so HOT 2
- Check use of NGX_RPATH in auto/runtime HOT 1
- Fix SIGFPE handling failure with Wasmtime in HUP mode HOT 1
- Fix Large CI annotation error on GitHub Actions HOT 1
- Fix V8 compilation in release workflow
- Fix Large CI failures
- segfault during ngx_proxy_wasm_ctx_lookup HOT 1
- coraza-proxy-wasm support HOT 11
- Fix V8 builds releases HOT 2
- Semantic of parameter `end_of_stream` for `proxy_on_http_*_headers()` differs from Envoy. HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx_wasm_module.