Backfiring pattern? about nucleus

[konmik]

I think that Presenter should not tell view to show something. Presenter in not controller. MVC does not work on Android, see "best practices" section.

I don't know what your Settings object is doing, but it seems to me that you can put all this code into your activity.

[konmik]

Yes, you can use onTakeView to push data from presenter to view if that data is needed every time a view is attached.

[jofor]

I would think this pattern becomes a little weird. Because this means you should at some cases couple activities with presenters and some not. Else you'll leave empty presenters around for no reason.

Imagine you have an application that has a simple wizard. The only thing that activity should do is present static views and during the wizard maybe write settings that will be saved in your application.

If code such the one above is supposed to be placed in the activity it means i should decouple the presenter for that specific activity, which would break the mvp-pattern.

Does not the mvp-pattern say you should couple: model->presenter->view to display something and the other way around view->presenter->model to store something?

You probably know more than me, but I know this for sure, there will be cases when the presenters will not be used for anything, which strikes me as odd :)

[konmik]

Reading preferences is not a task that deserves presenter. This is a one-line main thread action. Keep it stupid simple!

Yes, I use presenter only if I have background tasks to handle or if my database should be split off view. Overengineering is a real problem on big projects, this is why not every view should have them.

[jofor]

I'll try stick with that reference :)

[konmik]

You can create an observable from preferences if you wish and use deliver() to send data to view.

[jofor]

If one is to be able to make a project-specific baseactivity that makes easy interaction with both activities not using presenters and activities using presenters, I think a new annotation would have to be added in that case :)

if RequiresPresenter-annotation is used to tell that an activitiy needs a presenter, then it should be possible to also tell with an annotation that it does not need it, else you'll have to use two baseactivities for your activities, one that uses nucleusActivity and one that does not :)

[konmik]

If you make a project-specific base activity then just don't say that it requires a presenter. :-D

[jofor]

Then how will I make an activity than needs to be extended from that baseactivity that DOES require a presenter? :D

I tried the following

  public class BaseActivity<PresenterType extends nucleus.presenter.Presenter> extends     NucleusActionBarActivity<PresenterType> {
}

But if you remove the RequiresPresenter-annotation from the activities extending from it, and I just got an error that I needed to declare a Presenter for the activites using that baseactivity :)
So that didnt seem to work

It does seem like an issue

[konmik]

Ok, I will check this. Thank you for the report.

[konmik]

Done! :) 1.1.0