Comments (14)
@CompuGenius
Thanks for the suggestions.
- isTishaBav() is overkill since we do not have an isTzomGedalia(), isShivaasarBetamuz(), IsTaanisEsther etc. We do have isTaanis(). If you can make a good case for it, I will reconsider.
- JewishCalendar.isRoshChodesh() exists
- IsPurim() needs adjustments and setting such as isMukafChoma() for this to work for Yerushalayim and other cities.
- isYaalehVyavo() should return true for first and last days of Sukkos as well as Shavuos.
from zmanim.
@KosherJava thanks for your prompt reply.
- Regarding
isTishaBav()
, I created it for the Nacheim prayer by mincha. - I have version 2.4.0 implemented in gradle and there is no
isRoshChodesh()
function - only a const namedROSH_CHODESH
that is never used (from what I can tell). - That is a good point - forgot. How exactly would I go about validating which cities keep
SHUSHAN_PURIM
or not? - I specifically did not implement the days of Sukkos or Shavuos because, although I considered that there may be use cases for it, in my circumstance - a dynamic weekday siddur - it is not necessary, C"V.
from zmanim.
- Understood the need
- See isRoshChodesh(). I am not sure how it is missing in your version. Indeed the constant is not in use. I will review it.
- No way to validate. It is up to the developer to have a setting for it. I already coded it but it is not in GitHub yet. One thing I am not sure of is how to deal with places that have a safek. It is probably too much to deal with at this point, and the implementer can address it without the API.
- It would make sense for many non eSiddurim. An example would be a large shul display showing what part of davening is recited such as Parsha, Mashiv Haruach and Yaaleh Veyavo makes sense.
from zmanim.
- Obviously up to you, just think it would be helpful.
- That it indeed very strange. I just removed the gradle command as listed in the README and instead put what is suggested in #197, which caused gradle to rebuild due to different code, and now it is there. Strange indeed.
- Yeah, figured as much. Thanks
- Yeah, i figured these as use cases, I just did not bother implementing it myself. Since I knew this one would possibly need to be changed, I created an issue instead of bothering with a PR.
from zmanim.
As far as the constant ROSH_CHODESH, the main use of these constants are in getYomTovIndex(). That returns an int I am not sure that it is worth an effort in returning. I may change my mind down the line.
from zmanim.
@KosherJava I understand the usage of the constants, but ROSH_CHODESH
is never used.
Just wanted to point it out.
from zmanim.
Alright, the only dangling suggestion is isTishaBav()
for Nacheim, up to you to add.
Closing this now, thanks!
from zmanim.
I would have left it open until I actually addressed the items that can be addressed.
from zmanim.
Oh, I had figured that you had decided to not implement isTishaBav()
.
I also just realized I had forgotten about isAlHanissim()
and isYaalehVyavo()
lol.
from zmanim.
public boolean isPesach() {
int holidayIndex = getYomTovIndex();
return holidayIndex == PESACH;
}
public boolean isSuccos() {
int holidayIndex = getYomTovIndex();
return holidayIndex == SUCCOS || holidayIndex == HOSHANA_RABBA || holidayIndex == SHEMINI_ATZERES || holidayIndex == SIMCHAS_TORAH;
}
public boolean isShavuos() {
int holidayIndex = getYomTovIndex();
return holidayIndex == SHAVUOS;
}
public boolean isPesachHoliday() {
return isPesach() || isCholHamoedPesach();
}
public boolean isSuccosHoliday() {
return isSuccos() || isCholHamoedSuccos();
}
public boolean isYaalehVyavo() {
return isRoshChodesh() || isPesachHoliday() || isSuccosHoliday() || isShavuos();
}
Here's a proper isYaalehVyavo()
and helper functions related. I made a separate one for isPesach()
or isSuccos()
to match isShavuos()
and in case there ever is a want to just get those days.
from zmanim.
@CompuGenius ,
isCholHamoedPesach() and isCholHamoedSuccos() already exist. I will add isPesach() etc that will cover the entire YT and you can just call isCholHamoedPesach() or isCholHamoed() to determine things. Too many methods will confuse people.
As far as Yaaleh Veyavo, you missed RH, YK, Shmini Atzers and Simchas Torah. I will deal with it.
from zmanim.
isCholHamoedPesach()
andisCholHamoedSuccos()
already exist
I know that. I did not create those functions, rather just called them from my own.
I extracted each boolean to it's own function, which is definitely overboard, but you never know what people need 🤷
As far as Yaaleh Veyavo, you missed RH, YK, Shmini Atzers and Simchas Torah. I will deal with it.
I missed Rosh Hashanah and Yom Kippur, but if you look at my isSuccos()
function, it includes Shmini Atzeres and Simchas Torah.
from zmanim.
@CompuGenius , as far as I can tell, this is all done with the recent commits. Please let me know if anything was missed.
from zmanim.
LGTM 😁
from zmanim.
Related Issues (20)
- License under Apache or MIT License? HOT 1
- Why is getParsha defined only on shabbos/saturday HOT 11
- Change README gradle import syntax HOT 5
- Bain Hashmashos Spelled Hasmoshos
- isYomTov()
- add special Shabbasos
- check for machar_rosh_chodesh accounts for wday? HOT 1
- go-zmanim
- Yerushami Daf Yomi Trasliterated name error in order HOT 1
- Wrong formatter used on test output - LOW priority HOT 2
- In getDafYomiYerushalmi() [LastMischta, LastMesechtahMaxDaf + 1] returned for Daf 1 of Meschtas after Brachos HOT 2
- Spelling ? Kilayim כלאיים
- Flaw in logic? HOT 2
- Why use StringBuffer instead of StringBuilder? HOT 5
- Why Tfila vs. Tfilah?
- Spelling errors
- Identifying a zman?
- Add Mizmor Lesoda to TefilaRules HOT 10
- Cannot translate the parsha from the new API HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zmanim.