GithubHelp home page GithubHelp logo

Comments (2)

Kantis avatar Kantis commented on June 15, 2024

I think we should deprecate the method accepting the custom verifier. I think it's a bit problematic in this method.. My reasoning is as follows..

Given a custom verifier, there's no guarantees that the equality implementation is associative. Normally A == B and B == C implies that A == C. That might not be the case depending on how a user implements their verifier. This becomes a problem when implementing containsExactlyInAnyOrder.

When associativity applies, we can simply find any match to an element and it's equally fine to "consume" that match and move on and check if the rest of the elements manage to find a match. If all elements find a match, the assertion is a success.

Without associativity, we need to test every permutation of pairing the elements of the lists, otherwise we might end up with a false negative assertion.

from kotest.

Kantis avatar Kantis commented on June 15, 2024

Just noticed that this duplicates #3820 and a PR to fix it in #3821.. Will review that and contemplate for a bit.

from kotest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.