GithubHelp home page GithubHelp logo

Comments (3)

fzhinkin avatar fzhinkin commented on June 16, 2024 1
  • Should it be implemented only for new Klib format?
  • It will be a breaking change so should it be done before Klib finaly released?

In fact, Klib format already tracks parameters with default arguments, so it should be added only for JVM dumps. It indeed will be a breaking change, but the severity of the problem it solves justifies such a change.

Anyway, we can make a new behavior optional and, a few releases later, make it default.

  • Do you have an idea on how it could be done? Will it be some mark on each parameter having default value, or only the bitmask parameter will have some additional info?

I was thinking about printing all extra metadata near an affected declaration, but there is no particular proposal so far.

  • Do you think this change could be contributed by someone who is not familiar with the codebase? If so, I want to try to do it.

Sure! Feel free to implement and contribute it; let us just finalize how all the extra info should be presented in the dump first (I hope it'll happen within a few weeks).

from binary-compatibility-validator.

fzhinkin avatar fzhinkin commented on June 16, 2024

Sorry for the late reply. Indeed, it does make sense to capture information about parameters with default arguments in a generated dump.

from binary-compatibility-validator.

osipxd avatar osipxd commented on June 16, 2024

Great! I have the following questions:

  • Should it be implemented only for new Klib format?
  • It will be a breaking change so should it be done before Klib finaly released?
  • Do you have an idea on how it could be done? Will it be some mark on each parameter having default value, or only the bitmask parameter will have some additional info?
  • Do you think this change could be contributed by someone who is not familiar with the codebase? If so, I want to try to do it.

from binary-compatibility-validator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.