GithubHelp home page GithubHelp logo

After upgrading to kotlin 1.5.0, the kotlin-parcelize generated code started to be reported as public by binary-compatibility-validator about binary-compatibility-validator HOT 6 CLOSED

kotlin avatar kotlin commented on May 25, 2024
After upgrading to kotlin 1.5.0, the kotlin-parcelize generated code started to be reported as public by binary-compatibility-validator

from binary-compatibility-validator.

Comments (6)

4brunu avatar 4brunu commented on May 25, 2024 1

Here is the sample project

https://github.com/4brunu/kotlin-binary-compatibility-validator-issue

To dump the API, just run make or ./gradlew mylibrary:apiDump and check the result file under mylibrary/api/mylibrary.api.

Here is the api file with kotlin 1.4.32

Commit

mylibrary.api

Here is the api file with kotlin 1.5.0

Commit

mylibrary.api

from binary-compatibility-validator.

qwwdfsad avatar qwwdfsad commented on May 25, 2024

Hi, either the compilation strategy between Kotlin 1.4.x and 1.5.0 regarding parcelize has been changed or this is indeed the issue of BCV.

I'm not very familiar with parcelize, so if you could provide a sample project that reproduces the problem (e.g. I only update Kotlin/BCV version and the output of apiDump changes), it would significantly simplify the speed of the investigation and fix (if there will be any)

from binary-compatibility-validator.

4brunu avatar 4brunu commented on May 25, 2024

I will create one, thanks for responding so quickly 👍

from binary-compatibility-validator.

4brunu avatar 4brunu commented on May 25, 2024

This PR #60 didn't fixed this issue.
I tried with Kotlin 1.7.20 and binary-compatibility-validator 0.12.1 and it didn't worked.
Can we reopen this issue please?

from binary-compatibility-validator.

4brunu avatar 4brunu commented on May 25, 2024

@qwwdfsad or should I open a new one?

from binary-compatibility-validator.

qwwdfsad avatar qwwdfsad commented on May 25, 2024

Please open a new one with a reproducer as well

from binary-compatibility-validator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.