Comments (7)
...apologies, looks like github tried to get smart with the uname output.
from phar-util.
Did you encounter this error with previous version (0.5.2) of the package? I've had some reports ( http://blog.kotowicz.net/2010/08/hardening-php-how-to-securely-include.html#c2123438661706515019 ) that suggested errors with dot directories under Linux (i'm using php 5.2 under linux and all was working ok for me) - so I've made this incorrect change. I wanted to use the FilesystemIterator::SKIP_DOTS flag for the iterator, but it's PHP 5.3 only.
Could you check for me if changing $file->isDot() to $iterator->isDot() fixes the issue for you? I can't reproduce this.
from phar-util.
I did not have the problem with the previous version (I had just updated via pear today), but to fix it temporarily for myself, I just changed the isDot to this:
substr($file, 0, 1) != '.'
It's hackish, but it works well enough. I wanted to use $file[0], but as it is an object it's impossible.
I'll take a swing at $iterator real quick, though. Will reply with results.
from phar-util.
Seems to be working. !$iterator->isDot() doesn't seem to be allowing any problematic results to be included, and isn't throwing any errors.
from phar-util.
Then we're done with this - fixed in daeb346 .
btw - I'm really interested in how you use phar-util - drop me a note please, I've yet to receive any feedback from users ;)
from phar-util.
I'm using it for a personal project, it's probably the simplest interface for working with phar that I've seen yet. It's more or less to play with right now, until I find a serious use for it.
There's a few things that I've noticed that might be decent improvements, I'll open up an issue for each when I get the chance.
from phar-util.
Please do. Also, you can always fork it and fix the issues in your code and then send me a pull request.
from phar-util.
Related Issues (13)
- Use exit call on error? HOT 1
- RemotePharVerifier method "assertVerified" has borked docs
- error in condition in file RemotePharVerifier HOT 2
- Can't create self-executable phar. HOT 10
- RemotePharVerifier.php has a syntax error in 0.6.1 HOT 4
- Several test cases fail with errors
- Phar with Encryption
- Verify public key
- Pear channel/domain doesn't exist anymore HOT 1
- phar-build HOT 1
- phar-build always want to sign phar package HOT 1
- Comment stripping from files HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phar-util.