Request: ability to override cyanogenmod-specific behaviors without forking su code about superuser

[koush]

You shouldn't need to change access_disabled. You can set the prop like any other rom, and in fact would also work on stock. It's just a persist.sys setting.

[djp952]

But only if you have an "ro.cm.version" property set .. all the code in access_disabled() is skipped without it, preventing the specific Apps/ADB Access conditions from being checked at all.

I was thinking more about ROMs that would still like to have the Access settings to be functional, but don't necessarily follow all of the same rules as CM. I like to keep ro.debuggable set to "0" on all builds, for example. Based on the current code, even if I set an "ro.cm.version" property to something fake to enable the checks, all su access would just be denied because ro.debuggable is not "1". Stuff like that .... little differences that would break or limit some functionality.

No worries either way, this new Superuser is pretty fantastic as-is, and being 100% public it's just a couple clicks to fork and change the behavior slightly for different environments. Just thought it might be something that would come in handy and potentially reduce the amount of out-of-baseline code out there.

[koush]

Oh, I did not realize there was an ro.cm.version check; that is unnecessary (and vestigal code from the port). I've removed it and will check it in shortly.

[koush]

Yeah, I'll need to mess with this to handle defaults in CM vs the rest of the world. I'll fix this to accomodate your suggestions. I didn't realize this was completely busted on non-cm.