Comments (5)
The scope of this change might be quite large, since delegate
is used in about 80 call sites. My approach would probably be to change the Module#delegate
method to a singleton method, like
module Stupidedi
def self.delegate(klass, *params)
...
end
end
and then change each call site to look like Stupidedi.delegate(self, ...)
. This approach isn't much more than moving the method to a namespace, where it won't conflict with ActiveSupport.
I'd gladly accept a patch from you to do this, otherwise it may take a while for me to get around to doing it myself, simply because it's a low priority for me. Feel free to ask for help if you're interested in working on it! Solving this would probably solve the most important parts of #23.
from stupidedi.
cool! thx for the quick response, i would like to try this tomorrow
-=K=-
On Tuesday, February 4, 2014 at 8:36 PM, Kvle Putnam wrote:
The scope of this change might be quite large, since delegate is used in about 80 call sites. My approach would probably be to change the Module#delegate method to a singleton method, like
module Stupidedi def self.delegate(klass, *params) ... end endand then change each call site to look like Stupidedi.delegate(self, ...). This approach isn't much more than moving the method to a namespace, where it won't conflict with ActiveSupport.
I'd gladly accept a patch from you to do this, otherwise it may take a while for me to get around to doing it, simply because it's a low priority for me. Feel free to ask for help if you're interested in working on it! Solving this would probably solve the most important parts of #23 (#23).—
Reply to this email directly or view it on GitHub (#35 (comment)).
from stupidedi.
I guess fixed this delegate thing by follow your solution, but more issue come out from active_support which prevent me to work on my current rails app. In the meantime, i have to finish something in hurry and i would like to figure this out later.
Thanks a lot for the helps.
from stupidedi.
Hmm, sorry to hear more Rails issues are lurking. If you'll be occupied for a while, I'll happily accept a pull-request that fixed only the issue with delegate
. No problem with filing the other issues separately, when you have time.
from stupidedi.
Closing this issue as @irobayna fixed problems with delegate
in #41. Please open a new ticket if other problems remain.
from stupidedi.
Related Issues (20)
- Doesn't handle arbitrarily large input files, and never will be able to HOT 5
- Duplicate Keys HOT 3
- Unknown patient gender in 270 causes validation error HOT 2
- value PR is not allowed in element NM101 HOT 2
- Segment ST Does not occur HOT 2
- Parse EDI 850 ERROR HOT 1
- Accept Tempfile in Stupidedi::Reader.build HOT 1
- Segment N1*PR~ cannot be reached
- Parsing an 837 and grabbing segment values HOT 2
- Is there a way to skip validations and build without some of the segments HOT 2
- 004010 version - B3-07 precision doesn't work as intended HOT 2
- value 091 is not allowed in element DTM01 Date/Time Qualifier HOT 2
- TD1 for X12 Release 4010 gets reduced to 2 fields instead of 10 for no reason HOT 1
- 835 - 005010X221A1 - NTE segment error HOT 2
- Stream writing HOT 2
- help wanted: Only the first element is return when iterating a repeated element HOT 2
- Inconsistent floating point output in 834 ICM data HOT 9
- Adding the additional accepted values for a segement HOT 1
- File permissions issue on v1.4.3 HOT 9
- Load Error with Timezone Gem
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stupidedi.