TypeError: Cannot read property 'substr' of undefined about adaro

[aredridel]

Those versions aren't compatible. Is there a reason you're using a prerelease adaro?

[aredridel]

In general, though, that error means that Dust is getting templates compiled with a different version of dustc. Which makes sense, because adaro 1.0 includes its own dust (2.7), so using it with your own app's dust 2.6 (built using localizr or makara, I imagine) won't work.

[kurdin]

@aredridel

Sorry my mistake, the version of adaro is 0.1.10, yes [email protected] wont even install with [email protected].

We were using [email protected] all the time, then we notice the errors and I updated to [email protected], same problems.

[kurdin]

Which makes sense, because adaro 1.0 includes its own dust (2.7), so using it with your own app's dust 2.6 (built using localizr or makara, I imagine) won't work.

I will check that, thanks for direction.

[aredridel]

Good good. I'm trying to make a 1.0 release of a lot of this stuff but it's definitely a lot to untangle with the damage dust 2.7's changes brought.

Have you tried grunt build (if you're using kraken as generated) to build new .js compiled templates?

[aredridel]

You may also want to make sure you've only one copy of dust, npm ls dustjs-linkedin will show you all the copies in your project.

[kurdin]

Yes, I use grunt build then start app with NODE_ENV=testing nodemon index.js and I can see errors after, no errors in dev after nodemon index.js

Hmm, looks like only one dustjs to me:

[root@app]# npm ls dustjs-linkedin
[email protected] /home/gits/websites/app
└── [email protected] 

I checked app.js and grunt-dustjs everywhere console.log('dust.version: ', dust.version) outputs dust.version: 2.6.2

There must be something else.

[aredridel]

Good good. Just wanted to make sure of that.

What's your configuration for engine-munger?

[kurdin]

in config/config.json:

    "express": {
        "view cache": true,
        "view engine": "js",
        "views": "path:./.build/templates"
    },

...

    "view engines": {
        "js": {
            "module": "engine-munger",
            "renderer": {
                "method": "js",
                "arguments": [
                    { "cache": true,
                      "helpers": "import:./dust-helpers.json"
                    },
                    {
                        "views": "config:express.views",
                        "view engine": "config:express.view engine",
                        "specialization": "config:specialization"
                    }
                ]
            }
        }
    }

...

        "expressView": {
            "priority": 100,
            "enabled": true,
            "module": {
                "name": "engine-munger/lib/expressView"
            }
        },

npm ls engine-munger
[email protected] /home/gits/websites/app
└── [email protected]

I tried to upgrade to [email protected] but same errors so I keep [email protected]

[aredridel]

Okay. There's little difference, just version lock down of dust a bit. 0.2.5 should be fine.

[aredridel]

And the dust-helpers.json and specialization property you're referring to?

Can you paste one of the generated .js files from .build? I'd love to check the signature.

[kurdin]

dust-helpers.json

[
"../shared-modules/dust-helpers/price",
"../shared-modules/dust-helpers/dateFormat",
"../shared-modules/dust-helpers/combine",
"../shared-modules/dust-helpers/count",
"../shared-modules/dust-helpers/price",
"../shared-modules/dust-helpers/eval",
"../shared-modules/dust-helpers/lowercase"
]

specialization.json is empty for now :

{}

Regular Dust template:

{>"layouts/masterNew" /}
{<css_local}
    <link rel="stylesheet" type="text/css" href="/css/bootstrap-datetimepicker.min.css">
{/css_local}
{<body}
{#item}
    <h1>Test</h1>
{/item}
{/body}
{<scripts_local}

{/scripts_local}

Same compiled template:

(function(dust){dust.register("events\/reports",body_0);var blocks={"css_local":body_1,"body":body_2,"scripts_local":body_4};function body_0(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk.p("layouts/masterNew",ctx,{});}body_0.__dustBody=!0;function body_1(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk.w("<link rel=\"stylesheet\" type=\"text/css\" href=\"/css/bootstrap-datetimepicker.min.css\">");}body_1.__dustBody=!0;function body_2(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk.s(ctx.get(["item"], false),ctx,{"block":body_3},{});}body_2.__dustBody=!0;function body_3(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk.w("<h1>Test</h1>");}body_3.__dustBody=!0;function body_4(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk;}body_4.__dustBody=!0;return body_0;})(dust);

throw this error:

Server listening on http://localhost:8010
::ffff:192.168.2.10 - - [07/May/2015:15:08:54 +0000] "GET /events/reports?eventId=300507 HTTP/1.1" 304 - "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.37 Safari/537.36"
Thu, 07 May 2015 15:08:55 GMT uncaughtException Cannot read property 'substr' of undefined
TypeError: Cannot read property 'substr' of undefined
    at peg$parseraw (/home/gits/websites/app/node_modules/dustjs-linkedin/lib/parser.js:2152:16)
    at peg$parsepart (/home/gits/websites/app/node_modules/dustjs-linkedin/lib/parser.js:410:12)
    at peg$parsebody (/home/gits/websites/app/node_modules/dustjs-linkedin/lib/parser.js:393:12)
    at peg$parsestart (/home//gits/websites/app/node_modules/dustjs-linkedin/lib/parser.js:383:12)
    at parse (/home/websites/app/node_modules/dustjs-linkedin/lib/parser.js:2691:18)
    at Object.compiler.compile (/home/gits/websites/app/node_modules/dustjs-linkedin/lib/compiler.js:30:27)
    at /home/gits/websites/app/node_modules/adaro/lib/patch/index.js:82:64
    at /home/gits/websites/app/node_modules/adaro/lib/reader/js.js:39:13
    at fs.js:336:14
    at /home/gits/websites/app/node_modules/engine-munger/node_modules/graceful-fs/graceful-fs.js:104:5

Interesting thing that page is fully loaded, I can see completed HTML in browser and only then app gets that uncaughtException error.

@aredridel Thank you for helping.

[aredridel]

That looks an awful lot like a dustjs 2.7-compiled template. Can you clear that out and rebuild just to make sure?

[kurdin]

I added console.log('dust.version', dust.version); in node_modules/grunt-dustjs/tasks/dustjs.js

function compile (source, filepath, fullFilename) {
    var path = require("path"),
        dust = require("dustjs-linkedin"),
        name;

    console.log('dust.version', dust.version); 

    if (typeof fullFilename === "function") {
      name = fullFilename(filepath);
    } else if (fullFilename) {
      name = filepath;
    } else {
      // Sets the name of the template as the filename without the extension
      // Example: "fixtures/dust/one.dust" > "one"
      name = path.basename(filepath, path.extname(filepath));
    }

    if (name !== undefined) {
      try {
        return dust.compile(source, name);
      } catch (e) {
        grunt.log.error(e);
        grunt.fail.warn('Dust.js failed to compile template "' + name + '".');
      }
    }

    return '';
  }
};

Then:

[root@dev app]# rm -rf .build/
[root@dev app]# grunt build
Running "less:build" (less) task
File .build/css/app.css created.

Running "copyto:build" (copyto) task
Copied 67 files (0 unchanged), created 15 folders

Running "clean:tmp" (clean) task

Running "copyto:pretemplates" (copyto) task
Copied 176 files (0 unchanged), created 0 folders

Running "dustjs:build" (dustjs) task
dust.version 2.6.2
[dustjs] Compiled .build/tmp/templates/US/en/content-management/default-pages.js

... removed ...

dust.version 2.6.2
[dustjs] Compiled .build/tmp/templates/US/en/content-management/defaultpages/create/index.js
dust.version 2.6.2
[dustjs] Compiled .build/tmp/templates/US/en/events/reports.js

... long list removed ...

dust.version 2.6.2
[dustjs] Compiled .build/tmp/templates/US/en/travel-agents/quote.js

Running "copyto:templates" (copyto) task
Copied 176 files (0 unchanged), created 34 folders

Running "clean:tmp" (clean) task
Cleaning tmp...OK

Running "clean:build" (clean) task
Cleaning .build/tmp/...OK

[root@dev app]# cat .build/templates/events/reports.js 
(function(dust){dust.register("events\/reports",body_0);var blocks={"css_local":body_1,"body":body_2,"scripts_local":body_4};function body_0(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk.p("layouts/masterNew",ctx,{});}body_0.__dustBody=!0;function body_1(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk.w("<link rel=\"stylesheet\" type=\"text/css\" href=\"/css/bootstrap-datetimepicker.min.css\">");}body_1.__dustBody=!0;function body_2(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk.s(ctx.get(["item"], false),ctx,{"block":body_3},{});}body_2.__dustBody=!0;function body_3(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk.w("<h1>Test</h1>");}body_3.__dustBody=!0;function body_4(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk;}body_4.__dustBody=!0;return body_0;})(dust);

Same result

[aredridel]

Alright, I had my head too far up into the 'dust 2.7 broke everything' problem. You're right, those are not generated by a different dust.

[aredridel]

Do you have another config file overriding config.json?

Are you starting your app with NODE_ENV=production?

This error happens when .js templates get parsed as .dust templates.

[kurdin]

no, there is nothing in in config/production.json , just different port number:

{

    "server" : {
        "port" : 8000
    }

}

in config/development.json I have this:

{
    "express": {
        "view cache": false,
        "view engine": "dust",
        "views": "path:./public/templates"
    },

    "view engines": {
        "dust": {
            "module": "engine-munger",
            "renderer": {
                "method": "dust",
                "arguments": [
                    { "cache": false
                    },
                    {
                        "views": "config:express.views",
                        "view engine": "config:express.view engine",
                        "specialization": "config:specialization"
                    }
                ]
            }
        }
    },

And this should tell render, not any other ENV to use js templates, in my config/config.json:

  "express": {
        "view cache": true,
        "view engine": "js",
        "views": "path:./.build/templates"
    },

   "view engines": {
        "js": {
            "module": "engine-munger",
            "renderer": {
                "method": "js",
                "arguments": [
                    { "cache": true,
                      "helpers": "import:./dust-helpers.json"
                    },
                    {
                        "views": "config:express.views",
                        "view engine": "config:express.view engine",
                        "specialization": "config:specialization"
                    }
                ]
            }
        }
    },

[aredridel]

And which environment are you starting your node app in?

[kurdin]

right now, I use test:
NODE_ENV=test nodemon index.js

and config/test.json has same entry for port only :

{
    "server" : {
        "port" : 8000
    }
}

I installed dustc to make sure template is compiled with [email protected] , and I can confirm this is true:

[root@dev events]# dustc -v
dustc v2.6.2
[root@dev events]# dustc reports.dust
(function(dust){dust.register("reports",body_0);var blocks={"css_local":body_1,"body":body_2,"scripts_local":body_4};function body_0(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk.p("layouts/masterNew",ctx,{});}body_0.__dustBody=!0;function body_1(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk.w("<link rel=\"stylesheet\" type=\"text/css\" href=\"/css/bootstrap-datetimepicker.min.css\">");}body_1.__dustBody=!0;function body_2(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk.s(ctx.get(["item"], false),ctx,{"block":body_3},{});}body_2.__dustBody=!0;function body_3(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk.w("<h1>Test</h1>");}body_3.__dustBody=!0;function body_4(chk,ctx){ctx=ctx.shiftBlocks(blocks);return chk;}body_4.__dustBody=!0;return body_0;})(dust);

Same template as after grunt build

[kurdin]

This error happens when .js templates get parsed as .dust templates.

Hmm, I don't think ANY template will work at all if they parsed as dust vs js.

[aredridel]

Yeah. They shouldn't! But this is the specific error message that results.

[kurdin]

It doesn't make any sense, why that string cause the error stylesheet if I change it to xstylesheet even in compiled .js template, there will be no error.

[aredridel]

That is definitely odd.

Here's a thing: try dust 2.5. It has different escaping of template names, and there's a possibility that's breaking it. The hacks for dealing with that are .. ugly.

[kurdin]

Downgraded [email protected] and [email protected] same error. I don't think its dust :)

[aredridel]

Alright. good, so it's not the escaping change. That is really strange.

[aredridel]

Aye. I think to debug this I'm going to have to have a repro case.

[kurdin]

Looks like the problem is here: https://github.com/krakenjs/adaro/blob/v0.1.x/lib/patch/index.js#L81

src is undefined in some cases.

[aredridel]

Oh that is just fun.

[kurdin]

@aredridel do you need anything from me?

[aredridel]

A repro case would be awesome, a small app that demonstrates it. Building infrastructure to test this is going to be a pain!

[kurdin]

Let me see what I can do.

[aredridel]

Thank you! I'll poke at it eventually, though I'm in the process of streamlining the whole library to eliminate stuff like this in adaro 2.

[kurdin]

@aredridel
First of all, thank you for all your help and time. This was bug in our code (templates)

in file: public/templates/errors/404.dust

we had: {>"layouts/{sessionHelper.pageLayout}/master"/} and looks like {sessionHelper.pageLayout} was not set in controller on some pages, that would lead to src is undefined in https://github.com/krakenjs/adaro/blob/v0.1.x/lib/patch/index.js#L81

So I changed {>"layouts/{sessionHelper.pageLayout}/master"/} to {>"layouts/master"/} and errors are gone now.

May be in adaro you can try to check in src is undefined then show some message in logs.

Thanks again.