Comments (3)
It's not a bug. I would prefer not to make the API take n optional parameters, but instead a single content object, which is unwrapped as necessary for implementations. e.g.
var circuit = levee.createBreaker(function (context, cb) {
wreck.get(context.uri, context.options, cb);
}, circuitOptions);
circuit.run({ uri: '', options: {header: <someHeaderInfo>, timeout: timeOutValue}, function (err, req, payload) {
//...
});
Internally, this prevents slicing, mixing and matching, and rebuilding arguments and provides for function invocations with consistent argument types. If this is indeed a non-optimal API, we can discuss updating.
from levee.
I see. Let me dabble with it a little bit more to see if I can handle all use-cases in the servicecore.
from levee.
This should work. Thanks!
from levee.
Related Issues (11)
- Support for EventEmitters HOT 2
- Adding circuit status to stats will be helpful HOT 1
- Multiple requests HOT 2
- Support for streams HOT 1
- Basic example doesn't work HOT 1
- Levee is a synchronous library HOT 1
- Support Promises HOT 2
- hoek version needs to be updated, current version pollutes `object` prototype
- Can I do POST requests? HOT 1
- Support for running isFailure when request times out
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from levee.