GithubHelp home page GithubHelp logo

Comments (3)

totherik avatar totherik commented on August 20, 2024

It's not a bug. I would prefer not to make the API take n optional parameters, but instead a single content object, which is unwrapped as necessary for implementations. e.g.

var circuit = levee.createBreaker(function (context, cb) {
    wreck.get(context.uri, context.options, cb);
}, circuitOptions);

circuit.run({ uri: '', options: {header: <someHeaderInfo>, timeout: timeOutValue}, function (err, req, payload) {
    //...
});

Internally, this prevents slicing, mixing and matching, and rebuilding arguments and provides for function invocations with consistent argument types. If this is indeed a non-optimal API, we can discuss updating.

from levee.

pvenkatakrishnan avatar pvenkatakrishnan commented on August 20, 2024

I see. Let me dabble with it a little bit more to see if I can handle all use-cases in the servicecore.

from levee.

pvenkatakrishnan avatar pvenkatakrishnan commented on August 20, 2024

This should work. Thanks!

from levee.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.