GithubHelp home page GithubHelp logo

serialization / APC / igbinary. about apcu HOT 6 CLOSED

krakjoe avatar krakjoe commented on June 18, 2024
serialization / APC / igbinary.

from apcu.

Comments (6)

remicollet avatar remicollet commented on June 18, 2024

For your information : igbinary/igbinary#24
This fix seems simpler / better than the one propose in #21

from apcu.

weltling avatar weltling commented on June 18, 2024

Looking at here https://github.com/igbinary/igbinary/blob/master/config.m4 it wants apc/apc_serializer.h . Clear that the folder can be renamed from apcu to apc, but i'd say that's not the right way to do. Doesn't it look so that one should touch igbinary ext for compat? Maybe explicit options like --with-apc-path or --with-apcu-path which should be mutually exclusive. Just wanted to test together with igbinary but not sure how to do it right.

from apcu.

remicollet avatar remicollet commented on June 18, 2024

See #25

With this change (restore previous ABI) igbinary will work out of the box (using the bundled apc_serializer.h or apc one, or apcu one).

Of course a minor change to check ext/apcu folder is a cleaner solution (for the future).
As apc/apcu can't be both installed, so checking sequentially each folder in the config.m4 file seems ok (see igbinary PR, which need to be improved if this PR is accepted)

from apcu.

weltling avatar weltling commented on June 18, 2024

Actually the both can be installed but not loaded, so the headers of both might be laying around in the include path. That's good for apcu, but not apc users :) I think some WTFs from APC+igbinary users are to expect.

from apcu.

remicollet avatar remicollet commented on June 18, 2024

What would be the problem ? As far as the ABI is the same ?

from apcu.

weltling avatar weltling commented on June 18, 2024

Well, if user has both apc and apcu and compiles igbinary then hoping for apc but seeing apcu in the phpinfo(). For that reason i'd rather force user to choose one instead of doing it silently. With the same ABI it'd of course work, or at least it'll load together.

from apcu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.