suggestive change.... about adafruit_ili9341_menu

[tbillion]

Yes I did

…

On Wed, Oct 12, 2022, 8:45 AM canarin ***@***.***> wrote: did you manage to port it to tft espi? — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD3MNO5W3FJ2FNUUY4YVEETWC26HXANCNFSM56VUNKAQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[tbillion]

I'll upload the zip when I get home later tonight. Currently at work away from pc

…

On Fri, Oct 14, 2022, 7:55 AM canarin ***@***.***> wrote: Amazing! Could you and would you share the code maybe? — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD3MNOZUFVZFHNLIDR7LHWTWDFJ3NANCNFSM56VUNKAQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[jaksatomovic]

did you manage to port it to tft espi?

[KrisKasprzak]

I don't have immediate plans on supporting this library.

[KrisKasprzak]

If you are trying to port this lib to an adafruit based font's need to be passed by reference (use the & before the font name)

[jaksatomovic]

Amazing! Could you and would you share the code maybe?

[jaksatomovic]

Great! Thx a lot!

[jaksatomovic]

@tbillion looking forward to see the code..thx

[tbillion]

ILI9341_t3_Menu-mainmodded.zip

sorry @jaksatomovic been a busy few weeks, and ended up getting a new laptop during the last cycle so i had to move and sort everything back out. here is the library that i have modified to work with @bodmers tft_espi. @KrisKasprzak might want to verify that i have done it to his standards because he is a pretty outstanding coder, it really just hacked out the ili and inserted the tft. it does work here works really well, but results may vary in different environments.

[KrisKasprzak]

I took a look at the code, and making it work for other display libs was done correctly. Replacing the data type is correct and how I suggest in the readme. Well done.

Basically change every instance of one library data type to another
EditMenu(Adafruit_ILI9341 *Display,bool EnableTouch = false);
to
EditMenu(YOUR_DISPLAY_LIB_TYPE *Display,bool EnableTouch = false);

TIP for future display library adaptions: Depending on the way the display library handles setting fonts you may or may not need to make code changes (passing by ref with the &)--and these changes will be throughout the .cpp and .h files. For this reason I was not able to use a template approach to make the code easier to use with other libs.

Implementation for Teensy library (ILI9341_t3) is:
d->setFont(titlef);

Implementation for Adafruit (and I suspect many others) is:
d->setFont(&titlef);