Comments (8)
I might be misunderstanding, but the readme seems perfectly accurate to me. In particular,
when the underlying JavaScript engine will treat it as it does any unhandled exception
seems to exactly match what asap does.
from asap.
I do not think that the README is inaccurate, but I do agree that we should clarify what “as it does any unhandled exception” means for NodeJS, specifically with regard to our respect for domains.
from asap.
@domenic that part is fine, it's the rest that is untrue:
If a task throws an exception, it will not interrupt the flushing of high-priority tasks. The exception will be postponed to a later, low-priority event to avoid slow-downs, when...
from asap.
Oh hmm, looking at the code, you're right:
https://github.com/kriskowal/asap/blob/master/asap.js#L30-L47
Weird.
from asap.
I don't have a strong opinion on which behavior is better, as I'm still holding out hope for removing all exception handling from asap.
from asap.
Oh, I see. Yeah, that’s different.
from asap.
ASAP is already at version 1.0.0, and I think documentation should correctly reflect the current state of the code. Apparently there will not be a consensus very soon, so I think we should fix the paragraph as soon as possible, and to revert it in future if needed. I am going to create a new branch for that.
from asap.
It seems I forgot to close this one.
from asap.
Related Issues (20)
- Browserify Support HOT 15
- Cross library interleaving can cause node 10's nextTick limit to be hit. HOT 1
- Publish a new version HOT 4
- function to change rawAsap.capacity value must be added HOT 3
- Consider using Promise.prototype.then HOT 4
- asap queue can be effectively overflown (using [email protected]) HOT 2
- Usability in development mode with thrown errors HOT 5
- Browser field contains invalid route in npm HOT 8
- Microtask queue can be made faster HOT 4
- asap uses timer, not MutationObserver, in Safari HOT 1
- react-native throw Error when importing asap HOT 8
- Chrome + postMessage = slow HOT 1
- Source is poinitng to internal uber repo HOT 3
- npm published version 2.05 is not in git HOT 1
- Browser-asap requiring wrong raw file (non-browser version). HOT 4
- Does asap have an ECCN? HOT 2
- Contributors? HOT 1
- Use queueMicrotask? HOT 2
- esbuild fails: "browser" field is not according to spec
- TypeError: t.observe is not a function. (In 't.observe(l,{characterData:!0})', 't.observe' is undefined) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from asap.