GithubHelp home page GithubHelp logo

Comments (2)

KristofferC avatar KristofferC commented on June 3, 2024

That's a good idea!

There used to be a "debug" mode that you could activate that added some stats but it was removed in https://github.com/KristofferC/NearestNeighbors.jl/pull/98/files#diff-3d112593fe19c53f85f19846cc9d0406c17b39736378b65e7d12821d20207302.

With more experienced eyes, I think a better alternative is to allow one to pass something like a

struct EvaluationData
    n_distance_evals
    n_tree_intersection_evals
    ...
end

to inrange and knn and have that struct be populated. By default that argument would just be nothing and unused.

from nearestneighbors.jl.

fcdimitr avatar fcdimitr commented on June 3, 2024

I made a minor modification on my fork to include a global counter:

master...fcdimitr:NearestNeighbors.jl:master

It works correctly, and some preliminary benchmarking shows that it does not affect the running time.

In any case, I agree that a more structured approach to collecting statistics should be preferred.

from nearestneighbors.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.