GithubHelp home page GithubHelp logo

Comments (4)

kristopolous avatar kristopolous commented on September 25, 2024

Ok, let's see ... if you are going png -> jpg, then yes, you have to decide on how to coerce the png transparency to something ... of course something is currently being done and it's not appropriate for your use case.

Your use case would want to specify say, a 24 bit hexcode as the fill color. This all sounds reasonable. I'm looking over here http://www.imagemagick.org/script/resources.php and I don't see anything from the imagemagick side that would be an appropriate solution here.

However, I'm cautious against doing a fill color background and ignoring the possibility of say, a gradient or a mapped image background.

I think that those are certainly more exotic use cases, but the argument stands of whether this rationalizes anything at all should be done.

Oh heck, why not ... let's have a fill color. So be it.


On to issue 2.

The purpose of this project is to just convert images. That's the scope. Limiting the requests should be done at a separate layer. nginx and apache both have strong regex matching rules. I'm sure that there's quite a few other ways to go about it, but it probably shouldn't be solved here, just in the spirit of KISS.

Sorry about that.

from apophnia.

rklak avatar rklak commented on September 25, 2024
  1. OK.
  2. I understand KISS, but i dont want to have request that go through apache or nginx and then to apophnia. I would like to go directly to that server.

What you think? It will be a really complicated change? I leave you with it :)

Greetings!

from apophnia.

kristopolous avatar kristopolous commented on September 25, 2024

Ok, sure, I'll think about whether there's a "right" thing for me to do here; something in the spirit of what is currently done; flexible enough to be useful but restrictive enough to be easy and demonstrably functional.

But as an aside, you should really think about putting it in front of something like an nginx proxy, that was the intention of the product, you do a regex match for jpgs etc, send it off to apophnia, websockets send it off to node, etc ... things like that; it was so you can do image scaling without backing it up by lighty or apache (it was specifically for embedded devices, but that's another story)

Anyway, If you aren't comfortable with this kind of setup I can direct you to a few places that can give some examples; it's a really powerful style of doing things. If you simply don't like this approach however, then I happily welcome you to ignore the last two paragraphs. :)

Really, totally ignore it, I'm serious. This project is supposed to be a tool, not something that precipitates a specific workflow.

from apophnia.

rklak avatar rklak commented on September 25, 2024

Ok, thanks for feedback

from apophnia.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.