GithubHelp home page GithubHelp logo

Comments (8)

yannh avatar yannh commented on June 21, 2024

👍
Not working here either, pretty much same use case :(

from deb-s3.

dejo1307 avatar dejo1307 commented on June 21, 2024

I thought the same, and wanted to fix this, but code is actually working fine. We have versioning like 1.2.3-1234 and hit this same issue but in 1.2.3-1234 first part (1.2.3) IS version and second part (1234) is considered as iteration number. So we decided to change our nomenclature to be more Debian specific (you can change it to 1.2.3+1234 for example) and that should work with current code:

https://www.debian.org/doc/manuals/maint-guide/first.en.html#namever

So this previous line should look like:

@packages.delete_if { |p| p.name == pkg.name && "#{p.version}-#{p.iteration}" == "#{pkg.version}-#{pkg.iteration}" }

...but this is not OK regarding Debian naming convention.

from deb-s3.

maliksalman avatar maliksalman commented on June 21, 2024

So, in summary, I am running into this issue because the version numbers I am assigning to my 2 example packages above don't look different to the code?

from deb-s3.

yannh avatar yannh commented on June 21, 2024

Hello @maliksalman , indeed it seems you are having the same issue as we do, we believe the issue is because of the dashes in the version numbers. We are going to fix it by changing our versionning scheme. You might want to look at https://www.debian.org/doc/manuals/maint-guide/first.en.html#namever :

"You should choose the upstream version to consist only of alphanumerics (0-9A-Za-z), plus (+), tildes (~), and periods (.). It must start with a digit (0-9)."

from deb-s3.

zeridon avatar zeridon commented on June 21, 2024

Another report on this.

We are using Oracle Java and making packages based on make-java-package (make-jpkg)

this generates the following deb-names:
oracle-j2sdk1.7_1.7.0+update40_amd64.deb
oracle-j2sdk1.7_1.7.0+update51_amd64.deb

Which are prety much quite nicely ingested by any repo system we have used, but unfortunately deb-s3 leaves only the later one uploaded.

from deb-s3.

krobertson avatar krobertson commented on June 21, 2024

@zeridon are you using the latest 0.6.1 release? It includes #32 which addresses some issues with version handling with the preserve-version option. I believe it addressed the problem in this issue, but hadn't reviewed open issues before cutting the release.

from deb-s3.

zeridon avatar zeridon commented on June 21, 2024

Hi Ken,

i've installed it via gem but will check tomorrow from the release and report back.

from deb-s3.

zeridon avatar zeridon commented on June 21, 2024

Thanks 0.6.1 works, but maybe it should be a bit more visible that there is preserve-versions flag.

I.e. in the readme note that this gem mimics reprepro behaviour by default (keeps single version) or make the -p option visible in the default help and not only in upload

from deb-s3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.