Filenames with versions are wrong about deb-s3

[krobertson]

I've seen some issues with S3 and pluses, and also found recently that apt-transport-https has a bug with handling pluses. I'll take another review to double check.

Which version of deb-s3 are you running?

[mzupan]

deb-s3 (0.6.1)

[dwb]

I believe the issue is that the filenames in the Packages file are URL-escaped and they shouldn't be as per this Debian wiki page. I have a patch for this that I can PR tomorrow, it seems to have fixed similar issues for us that we've been having with colons in the filename.

[jnankin]

Although the filenames are fixed in the Packages manifest now (at least here in master, but not in rubygems), the uploaded filenames are now URL escaped so the manifest points to the wrong file.

So a file called "asdf+wheezy.deb" gets uploaded as "asdf%2Bwheezy.deb"

[jnankin]

I take that back. Here's the filename I'm dealing with:
"pool/f/fr/freeswitch-lang-pt_1.4.14+git20141209T231522Z1055ac8cf9-1~wheezy+1_all.deb"

So in the Packages manifest the filename contains +s, and the filename on S3 also contains +s, but the link created by S3 for the file contains %2Bs.

[BrianAdams]

I just tried with 7.1 and I am still seeing the the Filename in the actual repo files being URL encoded which it should not be.

From: http://deb-repo.rov.com/dists/pre-release/debian/binary-armhf/Packages

...

Package: rov-avrdude
Version: 1:5.11.1-1~24.ad04c42
License: unknown
Vendor: @04d7752423d9
Architecture: armhf
Maintainer: [email protected]
Installed-Size: 1478
Section: default
Priority: extra
Homepage: http://example.com/no-uri-given
Filename: pool/o/op/rov-avrdude_1%3A5.11.1-1~24.ad04c42_armhf.deb
Size: 482248
SHA1: d9a8834add57756de41eb68092471d6b3b3bfcff
SHA256: 542ae3f40f78ed722401891302867c10e258c45b67fe046e425e422ca3ec7a16
MD5sum: c023e18f2fea9b6d2620169948d09db0
Description: ROV avrdude package

Note the Filename: pool/o/op/rov-avrdude_1**%3A**5.11.1-1~24.ad04c42_armhf.deb above

I did confirm that #45 looks to be merged in master. Any ideas?

[BrianAdams]

I fixed the last issue I had in PR #77

[rmoriz]

still an issue with ~, e.g. 3.4.1-2~bpo80+1

Used 0.7.1 to upload to s3. It worked when url gets escaped, which seems not to be done by apt-get. If it's not "allowed" to put escaped URLs into the Release file, then this will not be able to get fixed, unless Amazon decides to auto-escape such requests.

[krobertson]

This issue has pingponged. I've had bugs filed with it both ways. I'm planning on just changing it to strip the problem characters from the filename.

[sigil66]

The root issue is S3 mangling + -> " ". https://github.com/sigil66/apt-transport-s3/blob/master/src/s3%2Bhttp.cc#L686

I hate this issue so very much.

[jnankin]

Is this fixed now?