Avoid overwriting old versions about deb-s3

[joscarsson]

You already have the flag --preserve-versions, but you want it the other way around?

[tfheen]

--preserve-versions is for not getting rid of old versions of packages from the manifest. It doesn't prevent me from uploading foo_1.0 if there already is a foo_1.0 in the archive, which is what I'd like.

[joscarsson]

I see. Does it really upload and overwrite the .deb if the .deb is already there? The transfer of the .deb was suspiciously quick, for me at least. I will investigate more, as soon as I get it working (#54).

[tfheen]

I'm fairly sure it does. I haven't tested it recently and so don't have backlogs to prove it.

[whiteley]

The package is overwritten but so are the manifests and the repository is left in a valid state. As long as the user has run apt-get update since the upload, the install will succeed without issue. I think the default behavior should be to not upload existing packages whether they have changed or not, both to save on transfers and to allow deb-s3 upload *.deb behavior.

@krobertson would you be fine with the --force-overwrite option as described? If so, I'm happy to put it together. Also, great package - thanks! 👍

[BrianAdams]

Just to add, if when overwriting, the system should check all of the other places that might have links to that same package and the manifest for those need to be refreshed with the new package. This is because a package with the same file name may have a different hash value (perhaps because it was signed at a different time) and the overwrite will break the other manifests if they are not updated.