Multiline comments removed? about pyscss

[Kronuz]

Yes comments are entirely removed as part of the parsing process... I know that's not entirely desirable always, but at the moment there's no way of keeping comments. We definitely need to find a way to have them.

[tghw]

This behavior does not follow the SASS language guidelines, which states multiline comments (delineated by /* and */) should be "preserved in the CSS output where possible" (http://sass-lang.com/docs/yardoc/file.SASS_REFERENCE.html#comments). I take this to mean that the comments will be kept as long as compression is off.

Can you expand on why "there's no way of keeping comments" at the moment?

[amery]

most probably because the "compiler" drops comments as whitespace very early

[tghw]

Yes, I see there is an explicit step to do this on https://github.com/Kronuz/pyScss/blob/master/scss/__init__.py#L781, but even if that call is removed, comments still seem to get taken out, but I'm not seeing where.

[Kronuz]

You can't simply remove that line that removes comments, the rest of the compiler expects those lines not to exist, and having them sill there would make the compiler try to treat them as rules. To make it work, one has to add a special rule type for comments (so it can added to the children of the current rule and later printed during the output). Then, locate_blocks() needs to know about the comments, looking for /* and */, and returning those "special" new rules. I'd add a @comment property rule, which it's block would be the comment itself... this way locate_blocks() would return @comment as a new property name, and the comment as the codestr. While printing, one would take those special rules, and print them as comments instead. It still would not be possible to gather all comments (specially those added inbetween selectors).

[eevee]

One other consideration: we may want to preserve top-of-file javadoc-style (/** ... */) comment blocks even when compressing, as these tend to be copyright notices or licenses or the like. e.g.:

[endorama]

Closing this issue because is too old. Feel free to reopen if necessary.