GithubHelp home page GithubHelp logo

Torch dependency about chamferdist HOT 5 OPEN

krrish94 avatar krrish94 commented on September 25, 2024 3
Torch dependency

from chamferdist.

Comments (5)

cdicle-motional avatar cdicle-motional commented on September 25, 2024 1

@krrish94 I think you can put something like

setup(
    ...
    install_requires=[
        ...
        'torch ~= 1.0 ;',
        ...
    ],
    ...
)

which should cover practically all torch versions but at least inform pip that the package depends on torch.

from chamferdist.

krrish94 avatar krrish94 commented on September 25, 2024

@cdicle-nutonomy This is an intentional omission -- the reason being everyone prefers using a different version of pytorch (based on their python/conda/pip/cuda configs)

from chamferdist.

krrish94 avatar krrish94 commented on September 25, 2024

Your point is well-taken though. We'll improve our messaging in the README to better articulate this pytorch dependency

from chamferdist.

krrish94 avatar krrish94 commented on September 25, 2024

This is a great point

from chamferdist.

GordonGustafson avatar GordonGustafson commented on September 25, 2024

Since the setup.py file currently requires torch, I don't think adding install_requires to setup.py will fix the issue, as the setup.py can't even be run until torch is installed.

The ideal solution is for wheels to be published to pypi, so the package can be installed without running setup.py. @krrish94 do you think that would be possible?

from chamferdist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.