Support for rediss TLS about cashews

[0xAlcibiades]

This would be useful for use over the internet.

[Krukov]

Oh yes, of course we should support redis with tls

If aioredis-py support rediss:// notation in uri it will be simple to add support for it.
Would you like to contribute?

[0xAlcibiades]

Yeah, so I did just try adding a match in the client, but it's a bit more complex than that because you have to allow for stuff like this: rq/rq#1468 I'd be glad to contribute the simple change around matching the backend, but not sure how/if you'd like to expose those extra parameters.

[Krukov]

I hope that it is not so complicated as you think, but I could be wrong 😅
We already can pass any parameters to the redis Connection class by setup method:

from cashews import cache 
from aioredis.connection import SSLConnection

cache.setup("redis://?ssl_keyfile=/tmp/test.key", connection_class=SSLConnection)
cache._backends[""][0]._client.connection_pool.connection_kwargs 
# that is kwargs that will passed to a redis connection class  https://github.com/aio-libs/aioredis-py/blob/56d6b325ee246a3eb0fc8bb6803247c86bb2f494/aioredis/connection.py
>>> {'ssl_keyfile': '/tmp/test.ssl', 'client_name': 'cashews', 'health_check_interval': 10, 'socket_keepalive': True, 'retry_on_timeout': False, 'socket_timeout': 0.1, 'decode_responses': False}

So maybe you can use redis over tls with code above, but I think that we should support rediss:// uri schema like aioredis do.

I hope that adding mapping to the settings_url_parse function will be enough, and using redis over tls will be look like:

from caches import cache

cache.setup("rediss://redis_host/1", ssl_cert_reqs=None)
# or
cache.setup("rediss://redis?ssl_ca_certs=/path/to/custom/ca-cert")

[0xAlcibiades]

Ok @Krukov please see and review my very small feature, then.

[Krukov]

Thanks @alcibiadeseth!
By the way, did you test it ? I am going to add it to the documentation, I want to be sure that its work )

[0xAlcibiades]

I tested it in the sense that it picks up the prefix, but not your bit about how to pass the additional parameters.

[Krukov]

Thanks you !
I have added documentation about rediss and released new version