GithubHelp home page GithubHelp logo

Comments (9)

Wagnerp avatar Wagnerp commented on June 15, 2024 1

@Wagnerp Proposal: Because the ##Dark and ##Light values are currently not overridden (Used) in the serialisation of the Palettes:

  • [] Remove from their current "General" location in the designer

  • [] Add new Area and values to the State### area with an appropriate named Key: i.e. RibbonFileAppButton

    • Use the existing values as the defaults, but not "Hard Code" them !
  • [] Wire up the usage of Disabled etc usages to use the ##Dark and ##Light overrides to follow the correct pattern

  • [] Update the Breaking Changes area to state correct usages of the RibbonFileAppButton values

Thoughts ?

@Smurf-IV Seems fine to me.

from standard-toolkit.

Smurf-IV avatar Smurf-IV commented on June 15, 2024

I would expect the following to have an input:
image

But even when they are empty a colour is still being found from somewhere.

from standard-toolkit.

Smurf-IV avatar Smurf-IV commented on June 15, 2024

Narrowed it down to these Palette values:
image

Nothing to do with the designer values above?!?

from standard-toolkit.

Smurf-IV avatar Smurf-IV commented on June 15, 2024

To get this:
image

Set these things in the designer:
image

from standard-toolkit.

Smurf-IV avatar Smurf-IV commented on June 15, 2024

To get this:
image

Set the following in the designer:
image

Which means that the RibbonAppButton is really the QATButton !
So the Explanation text needs to change because changing the Designer text will break all the serialisation of that object !!

from standard-toolkit.

Smurf-IV avatar Smurf-IV commented on June 15, 2024

@Wagnerp Proposal:
Because the ##Dark and ##Light values are currently not overridden (Used) in the serialisation of the Palettes:

  • Remove from their current "General" location in the designer
  • Add new Area and values to the State### area with an appropriate named Key: i.e. RibbonFileAppButton
    • Use the existing values as the defaults, but not "Hard Code" them !
  • Wire up the usage of Disabled etc usages to use the ##Dark and ##Light overrides to follow the correct pattern
  • Update the Breaking Changes area to state correct usages of the RibbonFileAppButton values
  • Fix Examples
  • Fix Theme Template editor
    Thoughts ?

from standard-toolkit.

Smurf-IV avatar Smurf-IV commented on June 15, 2024

This is happening:
image

And a new entry for the text (To make it clear what it is!)
image

from standard-toolkit.

Smurf-IV avatar Smurf-IV commented on June 15, 2024

Done so far:

  • Remove from their current "General" location in the designer
  • Add new Area and values to the State### area with an appropriate named Key: i.e. RibbonFileAppButton
    • Use the existing values as the defaults, but not "Hard Code" them !
  • Wire up the usage of Disabled etc usages to use the ##Dark and ##Light overrides to follow the correct pattern
  • Update the Breaking Changes area to state correct usages of the RibbonFileAppButton values
  • Fix Examples
  • Fix Theme Template editor

from standard-toolkit.

Smurf-IV avatar Smurf-IV commented on June 15, 2024
  • Remove from their current "General" location in the designer
  • Add new Area and values to the State### area with an appropriate named Key: i.e. RibbonFileAppButton
    • Use the existing values as the defaults, but not "Hard Code" them !
  • Wire up the usage of Disabled etc usages to use the ##Dark and ##Light overrides to follow the correct pattern
  • Update the Breaking Changes area to state correct usages of the RibbonFileAppButton values
  • Fix Examples
  • Fix Theme Template editor
  • [ ]
    SwitchFileTabColours

from standard-toolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.