Thread filter not working about jvm-profiling-toolkit

[krzysztofslusarski]

@ivansenic thank you, I fixed the issue, the filter didn't work properly if there were capital letters in thread name, one missing toLowerCase.

[krzysztofslusarski]

In thread filter you need to specify full thread name, the code for the matching:

    private boolean shouldInclude(IMemberAccessor<IMCThread, IItem> threadAccessor, IItem event) {
        if (threadAccessor == null) {
            return true;
        }

        String threadName = threadAccessor.getMember(event).getThreadName().toLowerCase();
        return threadName.equalsIgnoreCase(this.threadName);
    }

It uses equalsIgnoreCase to match filter to the thread in stack trace. The motivation is to extract single thread and in some application servers the prefix of the thread may be the same. For example tomcat threads:

http-nio-8080-exec-11
http-nio-8080-exec-1
http-nio-8080-exec-12

I want to have a possibility to filter out http-nio-8080-exec-1, that's why I use equalsIgnoreCase.

I believe the functionality for filtering a group of threads is also useful, I've committed a change to give such a possibility:

It's in the master. You can check it out.

[ivansenic]

Awesome thanks!

[ivansenic]

Tried out the contains filter, but it's not working..

[krzysztofslusarski]

Which mode are you using? Statefull JFR?

[ivansenic]

Yup

[krzysztofslusarski]

Can you share JFR and what filter you use?

If you can, pasqal [at] gmail.com

[ivansenic]

@krzysztofslusarski sent