Comments (5)
... reported by Aspilicious
from views3ui.
No, the pager to do a limited number of items is different from the pager to do all items, partly because SQL doesn't allow us to do an offset with all items. So the 'some' pager isn't supposed to accept 0 as a limit.
from views3ui.
Okay this makes sense, but
shouldn't 0 then lead to "display all items" pager plugin?
from views3ui.
Since the "add new view wizard" functionality isn't supposed to hit all use cases but rather only the most common ones, it doesn't seem like a huge problem to me if you can't create a view with unlimited items per page from there - since you can always go in and configure it to do that later, right? I think it would be a bit counterintuitive to type "0" for unlimited on that screen (without any explanation) though I guess it doesn't hurt much to leave it as a backdoor option for people who already know about it.
Either way, if http://drupalcode.org/project/views.git/commit/246ee7a is the commit you're referring to, it looks like it has some mistakes:
- The wizard has two "items per page" selectors (one for the page, one for the block) but it looks like your commit removed validation from only one of them. They should be kept in sync.
- Even if we allow 0 as an option, we don't want to remove the validation altogether. It's still the case that it needs to be a non-negative integer, right? :) So in that case it should be replaced with a different validation function.
from views3ui.
Finally this was reverted/
It doesn't make sense to support such a uncommon use case in the wizard
from views3ui.
Related Issues (20)
- Contextual links on the preview disappear after hitting "Cancel" in the modal dialog HOT 2
- Adding a display after editing a view via contextual links closes the edit screen HOT 1
- Node title in a views block disappears on the node page HOT 2
- Display format jumps to the right after using the "Show" dropdown on the wizard page HOT 1
- The "type" dropdown jumps to the left when you select it HOT 2
- The "Display Format" AJAX trigger doesn't work correctly HOT 1
- List of views. Operations wrap. Even when browsers width is large. HOT 2
- list of views. Filters needs some styling help, some options removed for gardens, and the "apply" button is not needed HOT 1
- Argument fieldset titles need work HOT 2
- Buggy behavior sometimes when the view is locked HOT 3
- Preview: arguments textbox HOT 2
- Grouping settings not visible? HOT 7
- Tweak the list filters (anything else?) HOT 1
- New views UI brakes fullcalendar views logic HOT 1
- indent radios for summary display (contextual filters) HOT 1
- Make access validation radios dependent on the parent checkbox and add margins to the validation option groups HOT 2
- Bug? with ctools export in views_get_all_views (ctools_export_crud_load_all) HOT 1
- Allow additional field-to-field conditions with the default views_join handler HOT 1
- What sort of license does this project have? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from views3ui.