trying to compile google/protobuf/descriptor.proto from protobuf-2.3.0 about protostuff-googlecode-exported

[GoogleCodeExporter]

"package", "rpc" and "service" are tokens declared in the lexer ... which is 
why its
complaining for mismatched input.  I'll try to find a workaround for that.

The fix for the enum having an optional semi-colon shouldn't be hard.

I believe forward references defined later in the file would work.  It might 
have
been the issue with the reserved tokens that is throwing the errors.

Btw, your message got cut short ... ending with "finally, it doesn't like "

Original comment by [email protected] on 12 May 2010 at 6:47

• Changed state: Accepted

[GoogleCodeExporter]

Committed partial fix (enum with trailing semicolon) @ rev 704

Original comment by [email protected] on 12 May 2010 at 7:03

[GoogleCodeExporter]

I've committed the fix for bugs mentioned. (rev 709)

Initially, the plan was to ignore the extensions.
Not yet sure about the approach to enable that.
Also, groups are also ignored.

Thanks for reporting.  Let me know if that works for you.

Original comment by [email protected] on 12 May 2010 at 11:38

[GoogleCodeExporter]

That works. Thanks for the speedy turnaround. The remaining problem is that 
some of 
the generated code is missing an import. 
http://code.google.com/p/wave-
protocol/source/browse/src/org/waveprotocol/wave/federation/federation.protodeve
l 
is the input, the output fails because it's missing 
UninitializedMessageException import.

Original comment by [email protected] on 12 May 2010 at 5:13

[GoogleCodeExporter]

svn up.  Should be ok now.

Thanks!

Original comment by [email protected] on 12 May 2010 at 5:49

[GoogleCodeExporter]

Nope. Now I get more brokenness - e.g. 
   [javac] Compiling 14 source files to /Users/arb/src/wave/fedone-json/build/bean
    [javac] /Users/arb/src/wave/fedone-
json/proto_bean_src/org/waveprotocol/wave/federation/ProtocolWaveletOperation.j
ava:179: ProtocolWaveletOperation() is already defined in 
org.waveprotocol.wave.federation.ProtocolWaveletOperation
    [javac]     public ProtocolWaveletOperation(
    [javac]            ^
    [javac] /Users/arb/src/wave/fedone-
json/proto_bean_src/org/waveprotocol/wave/federation/ProtocolDocumentOperatio
n.java:1250: ProtocolDocumentOperation() is already defined in 
org.waveprotocol.wave.federation.ProtocolDocumentOperation
    [javac]     public ProtocolDocumentOperation(
    [javac]            ^
    [javac] /Users/arb/src/wave/fedone-
json/proto_bean_src/org/waveprotocol/wave/examples/fedone/waveserver/Wavelet
Snapshot.java:179: WaveletSnapshot() is already defined in 
org.waveprotocol.wave.examples.fedone.waveserver.WaveletSnapshot
    [javac]     public WaveletSnapshot(
    [javac]            ^
    [javac] /Users/arb/src/wave/fedone-
json/proto_bean_src/org/waveprotocol/wave/federation/ProtocolWaveletOperation.j
ava:274: missing return value
    [javac]         return 
    [javac]         ^
    [javac] /Users/arb/src/wave/fedone-
json/proto_bean_src/org/waveprotocol/wave/federation/ProtocolDocumentOperatio
n.java:1309: missing return value
    [javac]         return 
    [javac]         ^
    [javac] /Users/arb/src/wave/fedone-
json/proto_bean_src/org/waveprotocol/wave/examples/fedone/waveserver/Wavelet
Snapshot.java:250: missing return value
    [javac]         return 
    [javac]         ^
    [javac] 6 errors

Attached one of the files as an example

Original comment by [email protected] on 12 May 2010 at 6:39

Attachments:

• WaveletSnapshot.java

[GoogleCodeExporter]

While you're there - it's useful in the real protoc output that it includes a 
line 
"generated from file x/y/z.proto" :)

Original comment by [email protected] on 12 May 2010 at 6:41

[GoogleCodeExporter]

Should be fixed now.

Yea it would be useful.
Will add it.

Original comment by [email protected] on 12 May 2010 at 7:38

[GoogleCodeExporter]

The "package" keyword error would probably be showing up in your IDE right 
about now :)

Original comment by [email protected] on 12 May 2010 at 7:42

[GoogleCodeExporter]

All (hopefully) of the fix is in trunk.

Add the option "underscore_on_vars" to avoid the keyword clash on java.
The option to include the source path (on the header) is in
http://code.google.com/p/protostuff/wiki/CompilerOptions as well.

Let me know if you still encounter problems.

Thanks!

Original comment by [email protected] on 13 May 2010 at 10:37

[GoogleCodeExporter]

Original comment by [email protected] on 20 May 2010 at 9:33

• Changed state: Fixed