Expander does not break long strings about jquery-expander

[kswedberg]

It doesn't break the string because it's also looking at the widow option's value. If you set that to 0 it should work.

$('#myws').expander({widow: 0});

Does that work for you? If so, feel free to close this issue. Thanks!

[iwasrobbed]

Thanks for the quick reply!

If I set widow to 0 then it places the "Read more" link next to every description, even if it doesn't meet the slice character requirement. I'm using the class name expandable, so for every element that has the expandable class it now has that link next to it even if it's only a few characters long.

[kswedberg]

Hi Rob, Sorry for the delay. I was on vacation until late last night. I'll try to take another look at this asap. Feel free to ping me if you don't hear from me again soon.

[iwasrobbed]

No rush, Karl! I just wanted to file it as an issue (and a rare one at that) while it was still on my mind

[kswedberg]

Funny, I should be more familiar with my own plugin. Try it this way:

$('#myws').expander({widow: 0, preserveWords: false});

[iwasrobbed]

Now it works for that edge case, but it shows "Read more" next to all strings even if they don't meet the slice requirement:

    $('.expandable').expander({
      slicePoint: 300,
      expandPrefix: '... ',
      expandText: 'Read more',
      preserveWords: false,
      userCollapse: false,
      widow: 0
    });

Gives:

 Music video by Ellie Goulding performing Lights. (C) 2011 Polydor Ltd. (UK)... Read more

Even though that string is less than 300 characters (so it shouldn't be showing Read more for it).

[kswedberg]

thx again! it actually revealed an unrelated bug, which I just fixed in the latest commit.

[iwasrobbed]

Works like a charm, thank YOU Karl!!!