Comments (3)
Hi there,
Thanks for the report. There is still, obviously, a lot of work that needs to be done with .expander('destroy'). Part of the problem lies in how I'm slicing and dicing the elements: I'm using regular expressions. Unfortunately, that means things get messed up sometimes, like when there are unordered lists involved (because I wrap everything in a <div>
, which is invalid as a parent of <li>
elements).
Anyway, I hacked an ugly fix to your particular problem. I put in on jsbin instead of jsfiddle because I needed better access to the console. Here it is: http://jsbin.com/eyohez/2 (you can see the code, too, by going to http://jsbin.com/eyohez/2/edit).
from jquery-expander.
Thanks, I figured there would be a manual way to undo the expanding. If I want to really use this for my purposes though, I'll have to find how to replace somewhat complex Jquery selectors with a javascript loop, as my outline function takes 10 seconds to complete on my average laptop with Chrome! We have very long articles (10,000+ words - they're reports really) that we display on a single page. This translates into thousands of DOM elements so I have to be conservative in how I traverse the page. For now I'll stick with altogether hiding the nonessential parts.
Anyway I'm just rambling outside of the scope of my initial report, thanks for clarifying what I can and cannot do with your plugin and offering a hack.
from jquery-expander.
I see! Yes, in your case you're probably much better off with a custom, streamlined solution. I'm going to close this issue for now, but if there is anything I can do to help, let me know.
from jquery-expander.
Related Issues (20)
- how to use in angular HOT 3
- Scroll back up after triggering "read less" HOT 4
- An option to start expanded would be useful HOT 4
- An event, like "expander.expanded" or "expander.contracted", after action (& animation) complete HOT 1
- Whitespace between span.read-more and span.details?
- preserveWord logic is flawed: strings of numbers are not preserved
- preserveWords: false not working HOT 4
- Publish to npmjs.org HOT 1
- OnSliced event HOT 1
- Expander inside iframe kills fancyBox keyboard navigation (prev/next via Arrow keys) HOT 3
- Issues with \n and white-space: pre-line; HOT 6
- Long url HOT 3
- A lot of <br> HOT 1
- position of collapse button HOT 1
- inline instead of inline-block HOT 1
- Space between spans creates space inside link HOT 2
- not working when i set data using ajax HOT 2
- Doesn't include aria-label as an option HOT 2
- Inaccurate slice for Chinese characters HOT 6
- Allow custom non-breaking elements
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jquery-expander.