GithubHelp home page GithubHelp logo

Comments (11)

Syulin7 avatar Syulin7 commented on June 14, 2024

IIRC, there is no way to set job status to failed. Perhaps we could add StartingDeadlineSeconds(similar to ActiveDeadlineSeconds.) in runPolic, which specifies the time a job can remain Created. If the job is not running by the end of this period, it would be set to failed.

from training-operator.

tenzen-y avatar tenzen-y commented on June 14, 2024

@hywell-h Did you try using backoffLimit?

from training-operator.

hywell-h avatar hywell-h commented on June 14, 2024

@hywell-h Did you try using backoffLimit?

when pod gose into ImagePullBackOff , the status.phase of pod is Pending, and restart count of pod is zero;So backoffLimit will not work, because pod has not reached the Completed or Failed state yet.

from training-operator.

tenzen-y avatar tenzen-y commented on June 14, 2024

@hywell-h Did you try using backoffLimit?

when pod gose into ImagePullBackOff , the status.phase of pod is Pending, and restart count of pod is zero;So backoffLimit will not work, because pod has not reached the Completed or Failed state yet.

Oh, that makes sense.
Did you try using ActiveDeadlineSeconds? But I understand the ActiveDeadlineSeconds wouldn't be resolved the root cause.

To give failure handling more flexibility, I guess that the training-operator needs to migrate to the batch/v1 Job from plain pods management, and then support JobPodFailurePolicy.

from training-operator.

kannon92 avatar kannon92 commented on June 14, 2024

This sounds like the motivation behind kubernetes/kubernetes#122300

from training-operator.

tenzen-y avatar tenzen-y commented on June 14, 2024

This sounds like the motivation behind kubernetes/kubernetes#122300

@kannon92 Yeah, that's right, but as I remember correctly, configurable pod-stuck errors was rejected by SIG-Node, right?

from training-operator.

Syulin7 avatar Syulin7 commented on June 14, 2024

Did you try using ActiveDeadlineSeconds? But I understand the ActiveDeadlineSeconds wouldn't be resolved the root cause.

Yes, the pod status is always pending and it does not trigger the ActiveDeadlineSeconds.

from training-operator.

kannon92 avatar kannon92 commented on June 14, 2024

@tenzen-y there was no rejection.

from training-operator.

tenzen-y avatar tenzen-y commented on June 14, 2024

@tenzen-y there was no rejection.

Ah, I see. As I recheck the issue, the next action seems to raise this topic in the SIG Node meeting.
We probably can move this forward in the next cycle since the current is under the enhancement freeze for the 1.30.

from training-operator.

kannon92 avatar kannon92 commented on June 14, 2024

Yea its mostly that I moved to Red Hat and I'm not as focused on batch related items so I don't really have the bandwidth to lead that one.

from training-operator.

tenzen-y avatar tenzen-y commented on June 14, 2024

Yea its mostly that I moved to Red Hat and I'm not as focused on batch related items so I don't really have the bandwidth to lead that one.

No worries. As I'm still there (WG Batch), let me check the enhancement in the next cycle if I can find enough time.

from training-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.