Determine whether generated code needs to be checked in about cluster-registry

[pmorie]

I have a strong preference toward:

• Checking in any generated code
• Checking in vendored dependencies

[ericchiang]

Regardless of checking in vendored dependencies, I would like to stress that cluster-registry must check in generated code to be compatible with non-bazel based projects.

As someone who needs to use the cluster-registry client and coming from an org that hasn't used bazel in the past, this is a blocker.

[pmorie]

Yes, I would prefer to check in any generated code as well.

…

On Wed, Oct 25, 2017 at 1:47 PM, Eric Chiang ***@***.***> wrote: Regardless of checking in vendored code, I would like to stress that cluster-registry must check in generated code to be compatible with non-bazel based project. As someone who needs to use the cluster-registry client and coming from an org that hasn't used bazel in the past, this is a blocker. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWXmMU5ZwXyIYAp8IwcCsI-1izLO05dks5sv3Q5gaJpZM4P40hI> .

[ericchiang]

Another note: because this repo doesn't commit its BUILD.bazel files, it's not possible to depend on the generated code even if you're using bazel. (I might be wrong since I'm newer to bazel)

[perotinus]

Generated code and BUILD files are now checked in.