GithubHelp home page GithubHelp logo

Comments (6)

andyzhangx avatar andyzhangx commented on July 26, 2024

/assign @ZeroMagic

from azurefile-csi-driver.

ZeroMagic avatar ZeroMagic commented on July 26, 2024

Need to add a mock file Client in the fake cloud firstly.
https://github.com/kubernetes/kubernetes/blob/b461633ff0534089f6bd98aea1cd4df596091b75/staging/src/k8s.io/legacy-cloud-providers/azure/azure_fakes.go#L47

from azurefile-csi-driver.

kushthedude avatar kushthedude commented on July 26, 2024

Hi @andyzhangx, I would like to solve this issue. Can you provide additional details on Unit Tests that need to be added for the following functions?

from azurefile-csi-driver.

andyzhangx avatar andyzhangx commented on July 26, 2024

@animeshk08 could you also take a look at this? thanks.

from azurefile-csi-driver.

animeshk08 avatar animeshk08 commented on July 26, 2024

The unit tests already exist here:

func TestCreateDisk(t *testing.T) {

Line coverage can be found here: https://coveralls.io/builds/32107068/source?filename=pkg/azurefile/azurefile.go#L364

Only lines 384-387 are prominently remaining, which cannot yet be covered due to the absence of the mock interface(see here).

from azurefile-csi-driver.

andyzhangx avatar andyzhangx commented on July 26, 2024

thanks

from azurefile-csi-driver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.