Comments (3)
/kind feature
I think that some sort of Ensure
method could be useful -- pass an object to Ensure
, and we ensure that it's either created or up-to-date. Not sure of the precise design, but I'd be happy to review PRs and such, if you've got time to submit one.
from controller-runtime.
I would be glad to attempt a PR, but there are some design issues to address first.
Sometimes you need the eventually existing object first from the apiserver so that you can update/sync only some fields. In order to do this, you need to call the Get
method, so this CreateOrUpdate
won't fit in any interfaces (Reader
or Writer
).
One workaround I'm employing right now is that I manually implement CreateOrUpdate
right into the reconciler (see https://github.com/presslabs/wordpress-operator/blob/51ece534c606a998807d7049a942e5c9de701646/pkg/controller/wordpress/wordpress_controller.go#L89).
What are your thoughts about this?
from controller-runtime.
it could probably be a helper method in utils that takes in a Reader/Writer.
from controller-runtime.
Related Issues (20)
- Upgrade problem (v0.15.2->v0.17.3): configuring namespace HOT 2
- [BUG]: goroutine leak when `leaderelection.NewLeaderElector` return error HOT 1
- [issue] regarding horizontal scaling for operators HOT 1
- [bug] setup-envtest unable to find version for linux HOT 8
- go install fails with "zip: not a valid zip file" error message HOT 1
- setup-envtest is stuck and fails to download any k8s version HOT 2
- 【bug】controller start concurrency bug HOT 5
- controllerutil: SetControllerReference does not allow disabling BlockOwnerDeletion
- Question: update status field HOT 2
- Need help to understand the Software Architecture for my Bachelor Thesis :) HOT 1
- how to set client dial timeout HOT 5
- ENVTest - cannot delete PVCs in BDD test HOT 5
- Server-side field validation should be strict by default HOT 2
- Status.Conditions is set to null after Client.Update is called HOT 2
- Add support for SSA into the fake client HOT 2
- Oben HOT 3
- Dynamic RESTMapper fails to load new Versions within a pre-existing Group on cache miss HOT 2
- Support onStart option in controller and webhook HOT 6
- Start function of manager object not always returns error if it happens. HOT 1
- Support per-request-level shouldBypassCache configuration in the client Reader implementation HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from controller-runtime.