Comments (10)
@phisco I think it's a good idea to take a closer look how setup and teardown are put together. I don't see any harm in running them as subtests similar to other steps like "Assess".
from e2e-framework.
Ping @vladimirvivien @harshanarayana given that I had your attention for the other issue 😬
from e2e-framework.
@harshanarayana, do you mean for the names in the features? Teardown and Setup steps can already define a name, which in the case of the Assess steps are used as name for their dedicated sub-test, while here they are just ignored. See here for an example of how we use it.
I would expect each of these steps to be executed in its own sub-test and to be shown as .../Teardown/<NAME_OF_THE_STEP>
for example here:
--- PASS: TestEnvironmentConfigDefault (30.30s)
--- PASS: TestEnvironmentConfigDefault/TestEnvironmentConfigDefault (30.30s)
--- PASS: TestEnvironmentConfigDefault/TestEnvironmentConfigDefault/CreateClaim (13.51s)
--- PASS: TestEnvironmentConfigDefault/TestEnvironmentConfigDefault/MRHasAnnotation (0.51s)
--- PASS: TestEnvironmentConfigDefault/TestEnvironmentConfigDefault/Teardown/DisableAlphaEnvironmentConfig (X.Ys)
or wthout the Teardown
part:
--- PASS: TestEnvironmentConfigDefault/TestEnvironmentConfigDefault/DisableAlphaEnvironmentConfig (X.Ys)
I'd have to check how this would play out with the current way setup teardown steps are handled.
from e2e-framework.
Cool @vladimirvivien, I can give it a look over the holidays and try opening a PR for it!
from e2e-framework.
+1 to this. This will be a very useful change.
from e2e-framework.
@phisco Do you happen to have a possible format for these setup/teardowns in mind in terms of naming them ? If so, please share that here ?
from e2e-framework.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle stale
- Close this issue with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
from e2e-framework.
/remove-lifecycle stale
from e2e-framework.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle stale
- Close this issue with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
from e2e-framework.
/remove-lifecycle stale
from e2e-framework.
Related Issues (20)
- Calling `Config`'s `Client()` in tests running parallel yields a data race HOT 6
- Create Kind Cluster without test Function HOT 6
- Allow adding custom labels and annotations when creating namespace HOT 3
- How to use BeforeEachTest HOT 13
- Ambiguous call to `cfg.Client()` in `CreateClusterWithConfig` HOT 4
- ,
- Do not share config across tests HOT 3
- Why does `-parallel` and `-fail-fast` can't be used together? HOT 7
- Running `t.FailNow()` in Assess does not fail the following assess HOT 4
- decoder.ApplyWithManifestDir fails to decode yaml with comments in it HOT 5
- Importing "sigs.k8s.io/e2e-framework/klient/conf" causes: ` k8s.io/api/flowcontrol/v1alpha1: module k8s.io/api@latest found (v0.29.3), but does not contain package k8s.io/api/flowcontrol/v1alpha1` HOT 7
- Better error output from Kwok provider HOT 2
- Embedded Local Registry HOT 2
- Test suite is executed even if the setup failed HOT 2
- CLI flags for "running only given features" will skip whole test if a feature in the env doesn't match the criteria. HOT 1
- Instructions in README are outdated and use deprecated functions HOT 5
- `Flux` Integration test with `kyverno` is flaking HOT 1
- imdario/mergo module rename is creating issues with go mod tidy HOT 2
- Handling of interrupt signal during long running tests HOT 1
- Cannot use features.TableRow
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from e2e-framework.