GithubHelp home page GithubHelp logo

Comments (9)

ideahitme avatar ideahitme commented on May 12, 2024

additionally there is a workqueue which helps to create a controller synchronized with a certain k8s resource state. Example: https://github.com/kubernetes/client-go/pull/65/files

from external-dns.

linki avatar linki commented on May 12, 2024

Thanks @ideahitme.

This is also a very valuable document: Writing Controllers

from external-dns.

justinsb avatar justinsb commented on May 12, 2024

We also could import the kops code e.g. https://github.com/kubernetes/kops/blob/master/dns-controller/pkg/watchers/servicecontroller.go

The abstractions are not necessarily any easier to understand, in my experience.

The top bug that everyone falls in to is start reading the results in, and not waiting until the List has completed before processing. So on a restart, you delete almost all the records, then repopulate them as the List proceeds.

The kops dns-controller builds an in-memory desired state of the world (https://github.com/kubernetes/kops/blob/master/dns-controller/pkg/dns/dnscontext.go), and then keeps tracks of which records are dirty. It then polls this for dirty records every N seconds, which gives us some change debouncing. Polling for dirty records is efficient, particularly in the "nothing changed" case.

from external-dns.

linki avatar linki commented on May 12, 2024

Joe Beda built another template for how a controller should look: https://github.com/jbeda/tgik-controller

from external-dns.

prydie avatar prydie commented on May 12, 2024

Our use-case for external-dns has latency requirements that the current reconciliation loop implementation isn’t ideally suited to. I’d be interested in picking this up if its still the direction the project wants to go in?

from external-dns.

fejta-bot avatar fejta-bot commented on May 12, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from external-dns.

fejta-bot avatar fejta-bot commented on May 12, 2024

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

from external-dns.

fejta-bot avatar fejta-bot commented on May 12, 2024

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

from external-dns.

k8s-ci-robot avatar k8s-ci-robot commented on May 12, 2024

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from external-dns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.