Inconsistent behavior between Azure DNS and Azure Private DNS about external-dns

[szuecs]

@khuedoan For migration purposes, I would say if we want to change the flag behavior, we need to have multiple steps:

1. provide the current (--domain-filter) style by adding --zone-filter
2. add a minor release to notify the other will change and everyone should migrate before the next minor release
3. next minor release will break the --domain-filter behavior.

I think the faster way to enable you would be to review and merge your PR.

[khuedoan]

I totally agree with that, if we decide to do so I'm happy to submit a new PR

[mloiseleur]

I understand this frustration of different behavior between both Azure providers.
Nonetheless, this current behavior of changing one parameter behavior when a second one is set is bad UserXP.

After reading the code, we noticed that --domain-filter actually filters the zone name, not the domain name in Ingress object

A parameter named domain-filter should filter domain name, not zone name.
So if I follow you correctly, this is that behavior that should be changed and fixed, for both Azure providers.

@Raffo @szuecs Wdyt ?

[khuedoan]

Sounds good to me 👍