GithubHelp home page GithubHelp logo

Comments (17)

denkensk avatar denkensk commented on August 23, 2024

/cc @ahg-g @alculquicondor
/assign @denkensk

from kueue.

k8s-triage-robot avatar k8s-triage-robot commented on August 23, 2024

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

from kueue.

alculquicondor avatar alculquicondor commented on August 23, 2024

/lifecycle frozen

from kueue.

alculquicondor avatar alculquicondor commented on August 23, 2024

This should be simple enough

/help

from kueue.

k8s-ci-robot avatar k8s-ci-robot commented on August 23, 2024

@alculquicondor:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

This should be simple enough

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from kueue.

kannon92 avatar kannon92 commented on August 23, 2024

Hello! I'm interested in pulling this issue.

I think the code changed a bit since this was posted.

Is

func (s *Scheduler) nominate(ctx context.Context, workloads []workload.Info, snap cache.Snapshot) []entry {
this the code that we want to run in parallel now?

from kueue.

ahg-g avatar ahg-g commented on August 23, 2024

Thanks Kevin and welcome to Kueue :)

Until we create scalability tests to understand where the bottlenecks are, this issue may not be a priority.

But another issue that needs some attention is #259; would you be interested in that one?

from kueue.

kannon92 avatar kannon92 commented on August 23, 2024

Yea, that sounds great! And thank you!

I've been attending the calls for the working group so I'm interested in helping out where I can.

from kueue.

ahg-g avatar ahg-g commented on August 23, 2024

Sounds good, feel free to assign it to yourself, for some reason I can't.

from kueue.

alculquicondor avatar alculquicondor commented on August 23, 2024

@kannon92 any progress on this?

from kueue.

kannon92 avatar kannon92 commented on August 23, 2024

I have made 0 progress on this.

from kueue.

alculquicondor avatar alculquicondor commented on August 23, 2024

Should we leave it open for other contributors or can you still handle it?

from kueue.

kannon92 avatar kannon92 commented on August 23, 2024

Yea, anyone who is interested should feel free to take it.

from kueue.

alculquicondor avatar alculquicondor commented on August 23, 2024

/help

from kueue.

kannon92 avatar kannon92 commented on August 23, 2024

/unassign @denkensk

from kueue.

alculquicondor avatar alculquicondor commented on August 23, 2024

/close

So far the biggest bottlenecks in Kueue have been the API calls, which @gabesaba optimized.

I don't think we need to introduce parallel computations yet.

EDIT: using locks could even cause performance regressions.

from kueue.

k8s-ci-robot avatar k8s-ci-robot commented on August 23, 2024

@alculquicondor: Closing this issue.

In response to this:

/close

So far the biggest bottlenecks in Kueue have been the API calls, which @gabesaba optimized.

I don't think we need to introduce parallel computations yet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

from kueue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.