Comments (5)
@yuanchen8911 There is no particular reason. It's ok to add the following lines to scheduler-plugins:
logs.InitLogs()
defer logs.FlushLogs()
The WordSepNormalizeFunc
is not necessary.
from scheduler-plugins.
@yuanchen8911 There is no particular reason. It's ok to add the following lines to scheduler-plugins:
logs.InitLogs() defer logs.FlushLogs()The
WordSepNormalizeFunc
is not necessary.
Thanks, @Huang-Wei
Here is logs.InitLogs
code. Looks like it does the initialization and klog setup. I suspect the klog output won't be written to kube-scheduler.log
without the initialization. Anyway, we should probably add it back. I'm opening a PR.
// InitLogs initializes logs the way we want for kubernetes.
func InitLogs() {
log.SetOutput(KlogWriter{})
log.SetFlags(0)
// The default glog flush interval is 5 seconds.
go wait.Forever(klog.Flush, *logFlushFreq)
}
from scheduler-plugins.
Added logs.InitLogs()
#100
from scheduler-plugins.
Fixed by #100.
/kind cleanup
/assign @yuanchen8911
/close
from scheduler-plugins.
@seanmalloy: Closing this issue.
In response to this:
Fixed by #100.
/kind cleanup
/assign @yuanchen8911
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from scheduler-plugins.
Related Issues (20)
- [Coscheduling] pending podgroup might lead to starvation by persistently assuming pods HOT 3
- Release 0.28 HOT 1
- Document helm repository url HOT 5
- Rejection due to timeout / unreserve HOT 9
- Regarding concurrency issues with the Reconcile method in the PodGroup controller HOT 1
- Code generation incorrect since 1.29 bump HOT 1
- add more meaningful fields to crd objects HOT 5
- update-codegen.sh does not work on M1 mac out of the box HOT 7
- replace deprecated methods HOT 2
- Fix CVE-2023-47108 in go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.42.0 HOT 1
- Migrate to contextual logging HOT 8
- Add support for ppc64le and s390x architectures HOT 2
- feat: migrate generate-internal-groups.sh to k8s.io/code-generator/kube_codegen.sh HOT 4
- [noderesourcetopology] incorrect accounting of hostlevel resources (ephemeral storage) with scope=container HOT 1
- Distroless build HOT 2
- Bug [Co-Scheduling]: Pods stuck pending when pods use volumes with a persistent volume claim. HOT 5
- schduler-plugin calls the filter interface but does not call (sort,score) types of interfaces HOT 5
- request: remove vendoring from this repo HOT 3
- Add ctx param and error return to EnqueueExtensions.EventsToRegister() HOT 2
- Release 0.29
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scheduler-plugins.