GithubHelp home page GithubHelp logo

Comments (35)

aglassman avatar aglassman commented on July 18, 2024 5

Thanks for working on this feature, it's been very helpful.

from enhancements.

therc avatar therc commented on July 18, 2024 1

I'm also working on node-local services, so perhaps I can help with this. That way, I can blame myself for the ensuing rebases. :-)

from enhancements.

thockin avatar thockin commented on July 18, 2024 1

from enhancements.

ncdc avatar ncdc commented on July 18, 2024

@rata do you think you'll be able to code this in time for 1.4?

from enhancements.

rata avatar rata commented on July 18, 2024

On Mon, Jul 25, 2016 at 07:58:11AM -0700, Andy Goldstein wrote:

@rata do you think you'll be able to code this in time for 1.4?

My plan was to start working on this on Tuesday, as I have an exam on Tuesday at
university. IS this too late?

I think the change can be not so hard, for the quick look I had at th code (it
seems we just created a skydns backend in kube-dns, and seems is easy to add
another type response, CNAME, for what I looked).

But if you are concerned about this, please go ahead and work on this! I can
maybe join later and test or something :-)

from enhancements.

ncdc avatar ncdc commented on July 18, 2024

@rata that should be fine. I was just checking in. Thanks!

from enhancements.

idvoretskyi avatar idvoretskyi commented on July 18, 2024

@smarterclayton @rata which SIG is responsible for this feature?

from enhancements.

ncdc avatar ncdc commented on July 18, 2024

I would assume network

from enhancements.

idvoretskyi avatar idvoretskyi commented on July 18, 2024

@ncdc thanks

from enhancements.

rata avatar rata commented on July 18, 2024

@ncdc @smarterclayton @thockin I'm more busy than I expected (at $DAYJOB and university) and I'm not sure I'll make it on time on this. Do you want to start working on this, and if I have some time maybe jump on this later?

from enhancements.

rata avatar rata commented on July 18, 2024

I'm really really sorry, and I wish I could work on this, but I'm already late (planned to start 2 days ago) and more busy than I expected. I think it's better to say this early so this gets implemented in 1.4. But I'm really really sorry :-/

from enhancements.

aronchick avatar aronchick commented on July 18, 2024

@smarterclayton Do you think you can find someone else to tackle? Or should we just punt to 1.5.

from enhancements.

rata avatar rata commented on July 18, 2024

@therc thanks again! :)

from enhancements.

idvoretskyi avatar idvoretskyi commented on July 18, 2024

@therc thank you for your help, assigned you as an assignee.

from enhancements.

goltermann avatar goltermann commented on July 18, 2024

In a meeting today, it was mentioned that this is missing v1.4. I'm moving to the v1.5 milestone. Please bring back to v1.4 if that's not accurate.

from enhancements.

therc avatar therc commented on July 18, 2024

Two more things needed: rejecting Ports (as already agreed with @thockin) and teaching kubectl about the new field.

from enhancements.

thockin avatar thockin commented on July 18, 2024

@therc Can you make sure the last few tickboxes are OK to be checked?

from enhancements.

idvoretskyi avatar idvoretskyi commented on July 18, 2024

Targeting GA in 1.5.

from enhancements.

therc avatar therc commented on July 18, 2024

This is mostly working already in 1.4, but it occurred to me that there's no way to create such a service from the command line without using a YAML/JSON file.

kubectl expose doesn't feel exactly right, because the whole point of ExternalName services is that there are no pods to be exposed. If that's still the way it's going to be done, the command line syntax will have to be changed from (-f FILENAME | TYPE NAME) ... to (-f FILENAME | --external-name NAME | TYPE NAME) ....

Opening an issue for that.

from enhancements.

thockin avatar thockin commented on July 18, 2024

kubectl create service is the correct command tree to explore

On Thu, Oct 13, 2016 at 9:04 AM, Rudi C [email protected] wrote:

This is mostly working already in 1.4, but it occurred to me that there's
no way to create such a service from the command line without using a
YAML/JSON file.

kubectl expose doesn't feel exactly right, because the whole point of
ExternalName services is that there are no pods to be exposed. If that's
still the way it's going to be done, the command line syntax will have to
be changed from (-f FILENAME | TYPE NAME) ... to (-f FILENAME |
--external-name NAME | TYPE NAME) ....

Opening an issue for that.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#33 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVPmK08AXwK1Yw0eao88qgktxZ2Qiks5qzlaXgaJpZM4JQHJ2
.

from enhancements.

thockin avatar thockin commented on July 18, 2024

@therc I don't think the CLI for this went in, did it? Any reason to not call what we have GA, anyway? Are you active on the CLI part or should we just open a new issue for it?

from enhancements.

jimmycuadra avatar jimmycuadra commented on July 18, 2024

This is stable in 1.5? Are there docs?

from enhancements.

idvoretskyi avatar idvoretskyi commented on July 18, 2024

@smarterclayton @therc can you confirm the feature development has been completed and issue can be closed?

from enhancements.

thockin avatar thockin commented on July 18, 2024

@therc Can we count on you for CLI wrapup? would love to close this...

from enhancements.

idvoretskyi avatar idvoretskyi commented on July 18, 2024

@thockin @therc sooo, any final decision?

from enhancements.

thockin avatar thockin commented on July 18, 2024

from enhancements.

therc avatar therc commented on July 18, 2024

Just got back from vacation and a hectic office move, working my way through email backlog.
I can pick up any leftover items, but I think kubectl create support was implemented by @adohe in kubernetes/kubernetes#34789
Was there anything else you had in mind? My next related step was allowing the built-in kubernetes.default service to also be an ExternalName service, to pave the way for a migration to api.kube-system or something along those lines. But if you have something else that's higher priority, I can tackle that first.

from enhancements.

thockin avatar thockin commented on July 18, 2024

from enhancements.

therc avatar therc commented on July 18, 2024

Unfortunately, I think only Clayton or another owner can edit the issue description. I just went through the checklist and it looks to me like everything can be ticked off.

Regarding "detailed docs and examples", I have something with more use cases, originally for internal use, that I have almost entirely re-purposed as a blog post. I'm not sure how kosher it is to add links from Kubernetes docs to random external blog posts; I suspect not very, given link rot and the like. Perhaps I could re-adapt it again as a tutorial in the docs repo? This issue can be closed anyway.

from enhancements.

thockin avatar thockin commented on July 18, 2024

DONE

from enhancements.

idvoretskyi avatar idvoretskyi commented on July 18, 2024

@therc @thockin does this feature target 1.6 (as per @mdelio modified milestone) or it has been finally implemented in 1.5 yet?

If this is still 1.6, I'd like to reopen it and keep in this state during the release.

from enhancements.

therc avatar therc commented on July 18, 2024

The main feature is in 1.5 already and can be used through YAML files. It's the kubectl support that will land in 1.6. I think it'd be worthy of a 1.5 cherrypick.

from enhancements.

adohe-zz avatar adohe-zz commented on July 18, 2024

@idvoretskyi @therc yes, the kubectl support land in 1.6, shall we cherrypick it against 1.5?

from enhancements.

liggitt avatar liggitt commented on July 18, 2024

We don't typically backport new features

from enhancements.

adohe-zz avatar adohe-zz commented on July 18, 2024

Get it~

from enhancements.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.