Comments (4)
This issue is currently awaiting triage.
If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted
label and provide further guidance.
The triage/accepted
label can be added by org members by writing /triage accepted
in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from ingress-nginx.
There is no interest in the project to keep adding new annotations on-demand. The reason is that the volume of unique important use-cases is too large to cater to all expectations. Meaning if annotations are created for all requirements, then it becomes a combination of limited use of huge maintenance effort, of non-generic annotations or other features.
Secondly, the planning and execution of the Gateway API is already underway. The Gateway API will impact many expectations and alter designs. So adding annotations is not a improvement.
Thank you for your other contribution of gRPC_timeout annotation. That timeout annotation exists for HTTP but not for gRPC. So its a generic use-case for all gRPC deployments and hence its a improvement.
Wait for comments from others.
from ingress-nginx.
sure, i don't want to add annotations directly in this repo, that will bring chaos (like you said). π
i just want a mechanism that support custom annotations at runtime, like https://docs.nginx.com/nginx-ingress-controller/configuration/ingress-resources/custom-annotations/.
- the nginx.tmpl can be mounted to controller
- the annotations can be added to ingress, and only effect when it has been defined in nginx.tmpl
so, we don't need to create a full set of codes for annotation, just expose a map of variables for tmpl.
οΌlet's see others π οΌ
from ingress-nginx.
I don't think this project's controller has the design & architecture for supporting anything resembling dynamic runtime annotations.
Wait for other comments.
from ingress-nginx.
Related Issues (20)
- SSL Handshake Failure When Mapping to External HTTPS Service (AWS CloudFront + S3) in Nginx Ingress HOT 4
- Error from server (NotFound): services "nginx-ingress-nginx-ingress" not found HOT 3
- Can't include $ in permanent-redirect URL annotation HOT 2
- strict-validate-path-type does not allow period/dot/. in Exact or Prefix path HOT 15
- Make Nginx auth_request module to be able to expose auth error body when needed HOT 3
- Confusing `namespace` label in SSL metrcis HOT 4
- Nginx 503 error why trying rewrite ingress address HOT 7
- [helm chart] Include optional "topologySpreadConstraints" in defaultbackend HOT 1
- CVE Finding HOT 1
- namespaced ingress doesn't work as expected HOT 12
- nginx proxy k8s service test pod internal normal, ep normal, but nginx can not proxy normally HOT 4
- Incorrect handling of long URLs [draft] HOT 17
- Upstream Prematurely Closed Connection While Reading Response Header From Upstream HOT 13
- Support `grpc_read_timeout` and `grpc_send_timeout` in annotations HOT 6
- removed GeoIP package as part of ingress nginx v1.9.4, Ingress pods in Crashloopbackoff status HOT 4
- `Client.Timeout exceeded` (30s) on validation webhooks when updating Ingress objects HOT 16
- Slack dead HOT 5
- Bind custom port - Feature or Bug? HOT 3
- nginx ingress - tcp services source ip not preserved HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ingress-nginx.