GithubHelp home page GithubHelp logo

Comments (2)

zetaab avatar zetaab commented on May 23, 2024

seems that /lib/systemd/system/containerd.service file contains in old instance LimitNOFILE=infinity but it does not exist anymore in kOps master.

from kops.

zetaab avatar zetaab commented on May 23, 2024

imo it is quite radical just remove that setting in #16151 without providing way to configure that and migrate projects to new behaviour. In slack conversation it was told that kops supports containerd nri already https://kops.sigs.k8s.io/cluster_spec/#nri-configuration and its possible to somehow configure ulimits using that. However, we should have somekind of window to migrate from old to new one, instead of just removing the old solution.

  1. we should mark this ulimit as deprecated and provide instructions how to migrate new way of doing
  2. delete this old ulimit behaviour in next release
  3. with boolean flag we could still allow the old behaviour longer.

This change is quite big. We have currently issues running databases in production because ulimit is limited to 1024. I have now done hotfix (own compiled version) to revert this ulimit change, but still we should have migration window for projects. Most of them are developers who are not interested of changing their deployment manifests just because something changes in platform itself. Also it might be problem for like third party helm charts, if those does not support specifying annotations for pods.

from kops.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.