GithubHelp home page GithubHelp logo

Comments (7)

HirazawaUi avatar HirazawaUi commented on May 23, 2024

/sig testing

from kubernetes.

aojea avatar aojea commented on May 23, 2024

@riendeau is like that, but then there are 2 additional steps

  1. make the changes
  2. promote the image that has been built with the postsubmit job
  3. update the repo to use the new image

More detail in https://github.com/kubernetes/kubernetes/tree/master/test/images#promoting-images

If you want to try, please make sure you are going to follow up with all the steps, you can see other promotions PRs too #123655

/help

from kubernetes.

k8s-ci-robot avatar k8s-ci-robot commented on May 23, 2024

@aojea:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

@riendeau is like that, but then there are 2 additional steps

  1. make the changes
  2. promote the image that has been built with the postsubmit job
  3. update the repo to use the new image

More detail in https://github.com/kubernetes/kubernetes/tree/master/test/images#promoting-images

If you want to try, please make sure you are going to follow up with all the steps, you can see other promotions PRs too #123655

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from kubernetes.

riendeau avatar riendeau commented on May 23, 2024

@aojea Thank you for this information! Is the manual building and testing of images described in that same document something that you would consider a prerequisite for a proposed change like this? Or is it safe to assume that the automated PR test bucket(s) would provide sufficient test coverage?

from kubernetes.

aojea avatar aojea commented on May 23, 2024

Or is it safe to assume that the automated PR test bucket(s) would provide sufficient test coverage?

I always trust the CI system 🤷

from kubernetes.

riendeau avatar riendeau commented on May 23, 2024

I always trust the CI system 🤷

Good enough for me! Leading off with #124382.

from kubernetes.

BenTheElder avatar BenTheElder commented on May 23, 2024

/triage accepted

from kubernetes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.