GithubHelp home page GithubHelp logo

Comments (5)

hshiina avatar hshiina commented on June 20, 2024 1

It looks that nothing is requested to the runtime when only a memory request is changed:

// Note: cgroup doesn't support memory request today, so we don't compare that. If canAdmitPod called during
// handlePodResourcesResize finds 'fit', then desiredMemoryRequest == currentMemoryRequest.

Even if a resizePolicy is RestartContainer, a container is not restarted in this case. requests.memory in a container status is copied from allocatedResources:

if memory, found := status.AllocatedResources[v1.ResourceMemory]; found {
requests[v1.ResourceMemory] = memory.DeepCopy()
}

I think the problem in this issue is that it takes 60-90 seconds to update requests.memory in a container status. Currently, this is updated at a regular resync for the pod because nothing triggers status update. It would be better to update it earlier.

from kubernetes.

k8s-ci-robot avatar k8s-ci-robot commented on June 20, 2024

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

from kubernetes.

dshebib avatar dshebib commented on June 20, 2024

/sig node

from kubernetes.

hshiina avatar hshiina commented on June 20, 2024

/assign

from kubernetes.

hshiina avatar hshiina commented on June 20, 2024

Could you please confirm if the requests.memory in the container status is updated to 400Mi 90 seconds after the resize request is patched?

from kubernetes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.