Define coding style guidelines about ed-209

[MoOx]

first reply for everywhere :)

[bloodyowl]

I vote for :

bot.addListener = addListener
function addListener(name, listener) {
  this.listeners[name] = listener
}

as it allows easy calling to references locked in closures more securely, without having to rely on the fact that it is still present in the object.

// Imports
var irc = require('irc')
  , fs = require('fs')
  , path = require('path')
  , util = require('util')
  , bot = require('./bot.js')
  , config, client, botInstance, i, l

as aligning variable names seems clearer to me than what they represent (and prevents a lot from forgetting a comma, which happened a few times in the code).

if(url.search(/photo/) > 0){
  // …
} else if(url.search(/status/) > 0){
  // …
}

because fuck.

and

$tweet = $(".opened-tweet").find(".js-tweet-text").first()

for the same reason.

[rhannequin]

What about semicolons? We have to agree on it.

I vote for:
Method declaration: see @mlbli.

Variable initialization: see @mlbli , even if I don't like left colons. Maybe we could make it aligned with equal sign.

Spacing: see @mlbli +

response.on("data", function(chunk) {
  dom += chunk
})

But,
no space between function and (chunk)?

Quotes : 'simple quotes'.

[bloodyowl]

Just let semicolons where they belong

[MoOx]

Y'a pas déjà des codings standards "généraux" ? Genre des trucs réutilisables et intégrable dans les IDE, rédigé par des crews de rockstars ?
J'avais ça avant, dans ECLIPSE \o/

[madx]

1_, 1, 2_, 1*, 1

*: I prefer spaces after keywords before opening parentheses (function (, if ()

Also, "else if" on its own line is an heresy.

[Nyalab]

idgaf