GithubHelp home page GithubHelp logo

Comments (7)

HinTak avatar HinTak commented on June 23, 2024

@pavpanchekha the above snippet (duplicated from inline comments) will go into the m124 release note when it gets written. For now, this snipplet is the only "migration" guide. If you could contribute some test code (to go into the pytest "tests" directory), preferably using images from skia's resources/images directory (most of our current tests are written that way, using test files from skia/resources/), that would be useful.

from skia-python.

HinTak avatar HinTak commented on June 23, 2024

#236 now contains tests for the 5 combos which corresponds to the old m87 FilterQuality settings. More to do, but these are sufficient to satisfy migration needs from m87. #236 can go out, while this stays open.

from skia-python.

pavpanchekha avatar pavpanchekha commented on June 23, 2024

Just to clarify—the old FilterQuality options will no longer be supported, and users should migrate to SamplingOptions?

from skia-python.

pavpanchekha avatar pavpanchekha commented on June 23, 2024

What kind of tests would be useful? Actually checking that images have been resized with various quality levels? Or just checking that drawing an image with a given sampling quality is possible?

from skia-python.

HinTak avatar HinTak commented on June 23, 2024

Yes:
https://github.com/HinTak/skia-python/blob/m124-public/relnotes/README.m124.md

For now I have only added those which had m87 equivalent, and check that the 6 are valid:
https://github.com/HinTak/skia-python/blob/m124-public/tests/test_samplingoptions.py

Some actually non-trivial tests closer to how users might use them would be nice.

from skia-python.

pavpanchekha avatar pavpanchekha commented on June 23, 2024

Just a nit—in your migration instructions above you wrote SkFilterOptions and SkMipmapMode a few times, it's not supposed to have the Sk prefix.

from skia-python.

HinTak avatar HinTak commented on June 23, 2024

Yes, I realised the extra sk afterwards - 7f6e2bb - the readme is copied from the tests/tests_samplingoptions.py and should work literally (after adding some "skia." prefix, or doing from skia import * [Not recommended, as there might be collisions/shadowing]).

from skia-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.