GithubHelp home page GithubHelp logo

Comments (4)

kyle-mccarthy avatar kyle-mccarthy commented on July 28, 2024

This has been a reoccurring issue, and I am not entirely sure what the best way to fix it is. I have included next as a peerDependency, but it's not working as I expected it would.

I'm not very well-versed in how peer deps work and would like to use the user's next-server rather than limiting it to the implementation of the next-server version that it was transpiled with. Maybe you could provide some insight? An easy work around would just for this lib to type the second arg of register as any, but this is a less than ideal solution IMO.

register method: https://github.com/kyle-mccarthy/nest-next/blob/master/lib/render.module.ts#L23

from nest-next.

boenrobot avatar boenrobot commented on July 28, 2024

I think the fact that next is also a required dependency may be the culprit. If the semver versions are incompatible, next-nest will get its own copy of Next, rathert than the main one.

That said, "9.1.4" should be semver compatible to "^9.0.6", so I'm not sure why a separate copy is given... or maybe npm always does it, not just on mismatches... I use yarn, which definetly doesn't do that, but instead hoists compatible deps.

Anyway, as a solution, change it to a devDependency I guess?

from nest-next.

kyle-mccarthy avatar kyle-mccarthy commented on July 28, 2024

@boenrobot Yup you are correct -- I had it is a peerDependency + dependency but it actually should be peerDependency + devDependency. I'll just pushed v9.1.1 with the correct package.json @ArrayKnight can you let me know if the new version resolves your issue?

from nest-next.

ArrayKnight avatar ArrayKnight commented on July 28, 2024

Sorry about the delayed response, I was on holiday. I can confirm that this has been fixed. Thank you

from nest-next.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.