Comments (3)
Hi there,
Thanks so much for this proposal. I love the added flexibility it would bring. Happy to accept a PR :)
If the new CaptureHandler
captures an IP address, perhaps add a configuration option so that is disabled by default. I think logging IP addresses should be opt-in rather than opt-out.
from footprints.
Glad to hear @kyranb 👍
I am thinking about splitting this into a few PRs that you can review individually - let me know if you think otherwise:
- Implement new interfaces - PR #36 - note I am using another (and hopefully better) name convention that my original post here
- Bugfix PR #38
- Implement logging of IP (default should be disabled) - PR #37
- Implement
TrackableInterface
PR #39 - Implement an "Upgrade" section in
README.md
with steps for upgrading to next major release
from footprints.
Issue closed - See PR implementations in comment above
from footprints.
Related Issues (20)
- Laravel 5.4 error HOT 3
- Testing on localhost (no cookie/visit being recorded) HOT 1
- user_id is always blank HOT 15
- using this in a RESTful project HOT 6
- Multiple models HOT 3
- Scheduled deletion of old unclaimed Visits HOT 1
- INSTALLATION FAILS HOT 1
- Case-sensitive PSR-4 autoloading: "Class 'Kyranb\Footprints\Jobs\AssignPreviousVisits' not found" HOT 1
- TrackVisit using authenticated user id HOT 3
- Tracking occurs after controller and not before
- Packagist auto update disabled HOT 1
- AssignPreviousVisits job fails when run asynchronously HOT 2
- Manually Creating a User Fails HOT 3
- Exclude robots HOT 2
- Problem identifying users when queued HOT 1
- Correct ordering problem for initial and final attribution data HOT 1
- SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'referrer_url' HOT 1
- UTM parameters as array = bug
- Error in cookie
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from footprints.