GithubHelp home page GithubHelp logo

Comments (2)

SamuelDeleglise avatar SamuelDeleglise commented on July 2, 2024

Actually, I realize, the current name is AcquisitionNotebookManager, which should imply that this stuff is a factory of "AcquisitionNotebook", which I believe it is not...

Then a more appropriate name would be AcquisitionManagerNotebook because it's returning "Acquisition"-objects, and this is the particular flavour of the AcquisitionManager that can be used in notebooks...

from labmate.

SamuelDeleglise avatar SamuelDeleglise commented on July 2, 2024

I think I now get the big picture, correct me if I am wrong:

  • There are two kinds of Data classes: AcquisitionData and AnalysisData (eventhough for some reason, the second is currently named AnalysisManager)
  • There's only one Factory class: AcquisionManager, that has attributes current_acquisition_data and current_analysis_data (eventhough the second is currently named am)

Please, could you clarify the naming ? at the moment it is close to impossible to decode what object is what due to the names being so cryptic

from labmate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.