tools.rectangular_to_polar / tools.polar_to_rectangular fails tests about plenoptic

[lyndond]

Turns out it is because a = torch.rand(...) had an entry exactly equal to zero, meaning the magnitude of the vector is zero.
This made its corresponding angle calculation nonsensical, and so angle comparison in assert torch.norm(b - B) < 1e-3 failed. I'm going to change the method by adding a constant offset and renormalizing.

def test_coordinatetransform(self):
        a = torch.randn(10, 5, 256, 256)
        b = torch.randn(10, 5, 256, 256)

        A, B = po.polar_to_rectangular(*po.rectangular_to_polar(a, b))

        assert torch.norm(a - A) < 1e-3
        assert torch.norm(b - B) < 1e-3
        torch.manual_seed(1)
        a = torch.rand(10, 5, 256, 256)
        ################ these two lines fix the issue ###############
        a = a + 0.1
        a = a / a.max()
        ####################################################
        b = po.rescale(torch.randn(10, 5, 256, 256), -np.pi / 2, np.pi / 2)

        A, B = po.rectangular_to_polar(*po.polar_to_rectangular(a, b))

        assert torch.norm(a - A) < 1e-3
        assert torch.norm(b - B) < 1e-3

[lyndond]

Fixed in PR #49