GithubHelp home page GithubHelp logo

TCPDriver MRO is broken about lantz HOT 1 CLOSED

sfinucane avatar sfinucane commented on September 26, 2024
TCPDriver MRO is broken

from lantz.

Comments (1)

hgrecco avatar hgrecco commented on September 26, 2024

Thanks for taking the time to review this. You are completely right. I introduced this bug in 1d02773
Feel free to issue a patch against the develop branch and I will merge it.

The original idea was that all drivers were going to have a send and recv method. But send and recv (implemented in TextualMixin) called raw_recv and raw_send. So TextualMixin was before the "Raw" class to force calling TextualMixin.send and TextualMixin.recv

I now realize this is wrong as we are bitten many times. These are the things of the API that we realized by using it in different test cases. The plan is to have raw drivers that communicate with the instrument by sending and receiving bytes. They will ONLY raw_send and raw_recv.

On top, we build Textual based drivers that communicate with the instrument by sending and receiving strings and they implement send and recv.

So textual mixin goes at the end as you suggested. Thanks again.

from lantz.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.